Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Chinese localization #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhangyuesai
Copy link

@zhangyuesai zhangyuesai commented Aug 1, 2024

Hi! Thanks for this convenient tool!

The previous Chinese translation is of poor quality. Much of it doesn't even make sense in the context. Here are a few examples:

  • astrogator_timeColumnHeader = Time Till Burn was translated into "燃烧时间", which means "the time to burn" or "burning duration".
  • In astrogator_outboundHyperbolicError = <<1>> is on an escape trajectory.\nCapture to see transfers., "escape" was translated into "逃生", which means "escape for life" instead of "escape from a celestial body".
  • In astrogator_planeChangeBurnsSetting = Generate plane change burns, "burn" was translated into "刻录", which means "CD burning", rather than "rocket engine burning".
  • astrogator_adjustNodesSetting = Adjust nodes with translation controls when RCS is off was translated into "当RCS关闭时调整带有平移工具的节点", which means "adjust nodes which have translation controls when RCS is off", rather than "adjust nodes using translation controls when RCS is off".

The list could go on but you can see my point. I'm not here to judge, but I was confused all the time when using the mod with the previous Chinese translation.

So, I'd like to improve the translation so it makes sense to actual Chinese players. Missing lines are added, too. I've tested my translation ingame and it looks good.

@HebaruSan HebaruSan added the bug label Aug 1, 2024
Copy link
Owner

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zhangyuesai, thanks so much for the improvements! I do not pretend to know anything at all about Chinese, so I must rely on contributions from users who do, as in #13. Your descriptions of the problems sound like the sort of thing I would expect from automated tools, so maybe that was a factor.

I added some comments about strings that are de-translated back into English here; please take a look if you have time.

GameData/Astrogator/Localization/zh-cn.cfg Outdated Show resolved Hide resolved
GameData/Astrogator/Localization/zh-cn.cfg Outdated Show resolved Hide resolved
@zhangyuesai zhangyuesai requested a review from HebaruSan August 29, 2024 12:16
Copy link
Owner

@HebaruSan HebaruSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @zhangyuesai!

(For this repository, I handle pull requests by merging their branches in my local copy and then pushing all of the changes when I'm ready to create a new release. I will include this PR when I do that, which will auto-close PR.)

@zhangyuesai
Copy link
Author

Thanks for this contribution @zhangyuesai!

(For this repository, I handle pull requests by merging their branches in my local copy and then pushing all of the changes when I'm ready to create a new release. I will include this PR when I do that, which will auto-close PR.)

I wasn't sure whether you wanted me to make the change or you've made the change yourself. Sorry if this was a late response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants