Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test modules write functions and roles #65

Open
wants to merge 2 commits into
base: submissions
Choose a base branch
from
Open

Test modules write functions and roles #65

wants to merge 2 commits into from

Conversation

gershido
Copy link
Contributor

The purpose of this PR is to improve the module submission process. Specifically, it adds the following additional tests for submitted modules:

  • Check the module's roles - for each role that is listed, check that it's criterion value matches a function in the module's ABI.
  • Check the module's write functions - for each write function that is listed, check that there is a matching function in the module's ABI, and vice versa.

@gershido gershido marked this pull request as ready for review July 11, 2024 12:17
@gershido gershido requested review from a team as code owners July 11, 2024 12:17
YamineRL
YamineRL approved these changes Jul 24, 2024
View reviewed changes
Copy link

@YamineRL YamineRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamineRL YamineRL YamineRL approved these changes

@scottrepreneur scottrepreneur scottrepreneur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gershido @scottrepreneur @YamineRL