Skip to content

chore: sync chains#984

Draft
GabrielMartinezRodriguez wants to merge 2 commits intogabriel/sync-configfrom
gabriel/sync-chains
Draft

chore: sync chains#984
GabrielMartinezRodriguez wants to merge 2 commits intogabriel/sync-configfrom
gabriel/sync-chains

Conversation

@GabrielMartinezRodriguez
Copy link
Contributor

Linked Issues

  • closes #XXX
  • closes HAPPY-XXX

Description

< DESCRIPTION GOES HERE >

  • Include all relevant context (but no need to repeat the issue's content).
  • Draw attention to new, noteworthy & unintuitive elements.
Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs are documented in the docs.
    Public APIS and meaningful (non-local) internal APIs are properly documented in code comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) with make changeset for
    breaking and meaningful changes in packages (not required for cleanups & refactors).

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@GabrielMartinezRodriguez GabrielMartinezRodriguez mentioned this pull request Jun 27, 2025
11 tasks
@cloudflare-workers-and-pages
Copy link

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: c5f0e54
Status: ✅  Deploy successful!
Preview URL: https://f40c8887.happychain.pages.dev
Branch Preview URL: https://gabriel-sync-chains.happychain.pages.dev

View logs

@GabrielMartinezRodriguez GabrielMartinezRodriguez added the draft Not ready for review label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

draft Not ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant