feat(faucet): wait tx inclusion#720
Merged
GabrielMartinezRodriguez merged 2 commits intomasterfrom May 21, 2025
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
5ba2f4a to
d3db028
Compare
HAPPY-517 Faucet: await tx inclusion before returning from the service
cf. #661 (comment)
|
not-reed
approved these changes
May 5, 2025
2f78932 to
3f8de75
Compare
d3db028 to
c7c4802
Compare
11 tasks
aodhgan
approved these changes
May 8, 2025
3f8de75 to
3bf00b1
Compare
c7c4802 to
bf2f73b
Compare
3bf00b1 to
40a224e
Compare
7fef662 to
0ad0f49
Compare
0ad0f49 to
8a3cf6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linked Issues
Description
Faucet await tx inclusion before returning from the service and then invalidate the happy balance to refresh it
Toggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
testnet, mainnet, standalone wallet, ...).
< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >
< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
Public APIS and meaningful (non-local) internal APIs are properly documented in code comments.
in a Markdown document.
make changesetforbreaking and meaningful changes in packages (not required for cleanups & refactors).