Skip to content

feat(faucet): wait tx inclusion#720

Merged
GabrielMartinezRodriguez merged 2 commits intomasterfrom
gabriel/faucet-wait-tx-inclusion
May 21, 2025
Merged

feat(faucet): wait tx inclusion#720
GabrielMartinezRodriguez merged 2 commits intomasterfrom
gabriel/faucet-wait-tx-inclusion

Conversation

@GabrielMartinezRodriguez
Copy link
Contributor

@GabrielMartinezRodriguez GabrielMartinezRodriguez commented May 5, 2025

Linked Issues

Description

Faucet await tx inclusion before returning from the service and then invalidate the happy balance to refresh it

  • Include all relevant context (but no need to repeat the issue's content).
  • Draw attention to new, noteworthy & unintuitive elements.
Toggle Checklist

Checklist

Basics

  • B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
  • B2. This PR is not so big that it should be split & addresses only one concern.
  • B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

  • C1. Builds and passes tests.
  • C2. The code is properly parameterized & compatible with different environments (e.g. local,
    testnet, mainnet, standalone wallet, ...).
  • C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

  • C4. I have performed a thorough self-review of my code after submitting the PR,
    and have updated the code & comments accordingly.

Architecture & Documentation

  • D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
    (2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
  • D2. All public-facing APIs are documented in the docs.
    Public APIS and meaningful (non-local) internal APIs are properly documented in code comments.
  • D3. If appropriate, the general architecture of the code is documented in a code comment or
    in a Markdown document.
  • D4. An appropriate Changeset has been generated (and committed) with make changeset for
    breaking and meaningful changes in packages (not required for cleanups & refactors).

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 5, 2025

Deploying happychain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8a3cf6b
Status:⚡️  Build in progress...

View logs

Copy link
Contributor Author

GabrielMartinezRodriguez commented May 5, 2025

@linear
Copy link

linear bot commented May 5, 2025

HAPPY-517 Faucet: await tx inclusion before returning from the service

cf. #661 (comment)

I think the service should await inclusion of the tx, so we can simply await response from the server on the wallet and invalidate the token balance query when the faucet completes. This will lead to a smooth flow: click > sending... > token sents, balance is updated.

@GabrielMartinezRodriguez GabrielMartinezRodriguez added the reviewing-1 Ready for, or undergoing first-line review label May 5, 2025
@aodhgan aodhgan added merge-blocked Ready to merge, waiting for downstack and removed reviewing-1 Ready for, or undergoing first-line review labels May 8, 2025
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/txm-transaction-callbacks branch from 3f8de75 to 3bf00b1 Compare May 12, 2025 10:41
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/faucet-wait-tx-inclusion branch from c7c4802 to bf2f73b Compare May 12, 2025 10:41
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/txm-transaction-callbacks branch from 3bf00b1 to 40a224e Compare May 21, 2025 08:56
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/faucet-wait-tx-inclusion branch 2 times, most recently from 7fef662 to 0ad0f49 Compare May 21, 2025 09:12
Base automatically changed from gabriel/txm-transaction-callbacks to master May 21, 2025 09:27
@GabrielMartinezRodriguez GabrielMartinezRodriguez force-pushed the gabriel/faucet-wait-tx-inclusion branch from 0ad0f49 to 8a3cf6b Compare May 21, 2025 09:29
@GabrielMartinezRodriguez GabrielMartinezRodriguez merged commit cff83ee into master May 21, 2025
1 of 3 checks passed
@GabrielMartinezRodriguez GabrielMartinezRodriguez deleted the gabriel/faucet-wait-tx-inclusion branch May 21, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-blocked Ready to merge, waiting for downstack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants