feat(iframe): add request popup for eth_signTypedData_v4 requests#705
Open
ultraviolet10 wants to merge 3 commits intomasterfrom
Open
feat(iframe): add request popup for eth_signTypedData_v4 requests#705ultraviolet10 wants to merge 3 commits intomasterfrom
ultraviolet10 wants to merge 3 commits intomasterfrom
Conversation
Deploying happychain with
|
| Latest commit: |
f2975be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f6d08db.happychain.pages.dev |
| Branch Preview URL: | https://aritra-eth-signtypeddata-v4.happychain.pages.dev |
HAPPY-500 Implement `eth_signedTypedData_v4` request frame.
cf. HAPPY-235 for some background Key highlight:
|
ultraviolet10
added
reviewing-1
not-reed
reviewed
May 5, 2025
apps/iframe/src/requests/approved.ts
Outdated
Comment on lines
+78
to
+80
| case "eth_signTypedData_v4": { | ||
| return await sendToWalletClient(request) | ||
| } |
Contributor
There was a problem hiding this comment.
isn't this the default? i think you don't need this
Contributor
Author
There was a problem hiding this comment.
file moved to src/requests/approved.ts where the code doesn't exist, hence this is handled!
apps/iframe/src/requests/injected.ts
Outdated
Comment on lines
+78
to
+80
| case "eth_signTypedData_v4": { | ||
| return await sendToInjectedClient(app, request) | ||
| } |
Contributor
There was a problem hiding this comment.
isn't this the default? i think you don't need this
Contributor
Author
There was a problem hiding this comment.
same as above :)
ultraviolet10
force-pushed
the
aritra/eth_signTypedData_v4
branch
from
d994330 to
f2975be
Compare
not-reed
approved these changes
May 21, 2025
| * | ||
| * This is used to safely recurse into nested structs defined in EIP-712 typed data. | ||
| */ | ||
| function isObject(value: unknown): value is Record<string, unknown> { |
Contributor
There was a problem hiding this comment.
this should probably live in common utils i think 🫡
| <FormattedDetailsLine>{domain.version}</FormattedDetailsLine> | ||
| </div> | ||
| )} | ||
| {(typeof domain.chainId === "number" || typeof domain.chainId === "bigint") && ( |
Contributor
There was a problem hiding this comment.
nipick/suggestion/preference 😄
Suggested change
| {(typeof domain.chainId === "number" || typeof domain.chainId === "bigint") && ( | |
| {['number', 'bigint'].includes(typeof domain.chainId) && ( |
not-reed
added
reviewing-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Description
Added support for handling
eth_signTypedData_v4requests in the iframe component. This implementation:EthSignTypedDatav4.tsxthat renders EIP-712 structured data in a user-friendly format.Toggle Checklist
Checklist
Basics
norswap/build-system-caching).Reminder: PR review guidelines
Correctness
testnet, mainnet, standalone wallet, ...).
< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >
< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >
and have updated the code & comments accordingly.
Architecture & Documentation
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
Public APIS and meaningful (non-local) internal APIs are properly documented in code comments.
in a Markdown document.
make changesetforbreaking and meaningful changes in packages (not required for cleanups & refactors).