Implement EIP-5792 functionalities by ultraviolet10 · Pull Request #449 · HappyChainDevs/happychain

ultraviolet10 · 2025-02-19T10:41:50Z

Linked Issues

closes https://linear.app/happychain/issue/HAPPY-163/implement-wallet-sendcalls-and-capabilities

Description

This PR implements request handlers within the iframe for the specified RPC requests that make a wallet EIP-5792 compliant.

Currently, wallet_sendCalls only successfully handles sending one userOp since we don't support batching yet (spec in progress)

We define a new boopPaymaster capability in which devs can specify the address of a deployed paymaster and we use that in the sendUserOp handler.

Toggle Checklist

Checklist

Basics

B1. I have applied the proper label & proper branch name (e.g. norswap/build-system-caching).
B2. This PR is not so big that it should be split & addresses only one concern.
B3. The PR targets the lowest branch it can (ideally master).

Reminder: PR review guidelines

Correctness

C1. Builds and passes tests.
C2. The code is properly parameterized & compatible with different environments (e.g. local,
testnet, mainnet, standalone wallet, ...).
C3. I have manually tested my changes & connected features.

< INDICATE BROWSER, DEMO APP & OTHER ENV DETAILS USED FOR TESTING HERE >

< INDICATE TESTED SCENARIOS (USER INTERFACE INTERACTION, CODE FLOWS) HERE >

C4. I have performed a thorough self-review of my code after submitting the PR,
and have updated the code & comments accordingly.

Architecture & Documentation

D1. I made it easy to reason locally about the code, by (1) using proper abstraction boundaries,
(2) commenting these boundaries correctly, (3) adding inline comments for context when needed.
D2. All public-facing APIs & meaningful (non-local) internal APIs are properly documented in code
comments.
D3. If appropriate, the general architecture of the code is documented in a code comment or
in a Markdown document.
D4. An appropriate Changeset has been generated (and committed) for changes that touch npm published packages (currently pacakges/core and packages/react), see here for more info.

ultraviolet10 · 2025-02-19T10:42:06Z

wip: eip5792 rpc call implementations [skip ci] #523
Implement EIP-5792 functionalities #449 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-02-19T10:42:25Z

Deploying happychain with Cloudflare Pages

Latest commit:	`9b310f1`
Status:	✅ Deploy successful!
Preview URL:	https://c4e619c8.happychain.pages.dev
Branch Preview URL:	https://aritra-eip-5792.happychain.pages.dev

View logs

linear · 2025-02-19T10:47:02Z

HAPPY-163 Implement `wallet_sendCalls` and capabilities

Implement EIP-5792 (EIP) (wallet_sendCalls and capabilities)

we need to add a custom onchainPaymaster capability (the existing paymasterService doesn't fit, they're for service paymasters)
we need to support the atomicBatch capability and map it to a transaction batch sent to the bundler

ultraviolet10 · 2025-02-19T11:59:13Z

apps/iframe/src/components/requests/WalletSendCalls.tsx

this is a placeholder, the actual component is being written in a separate PR

ultraviolet10 · 2025-02-19T12:00:15Z

apps/iframe/src/requests/approved.ts

+                })
+            }
+
+            return userOpHash


we could have sent the txs sequentially in the for loop but the spec mentions we should return only a singular hash

it also says its a call identifier to check the status of the call, and not needed to be a transactionHash/userOp hash... maybe its a hash of all included userOps? just using the last one feels a bit arbitrary to me 🤔

if its an atomicBatch as mentioned before, then this would just return a single userOp anyways right? but if its not an atomicBatch, then only having the last userOp seems not ideal as a lookup key

ultraviolet10 · 2025-02-19T12:01:09Z

apps/iframe/src/requests/approved.ts

+            }
+
+            // extract specified paymaster address from capabilities
+            const boopPaymasterAddress: Address | undefined = callsData.capabilities?.boopPaymaster?.address


in this manner, we will also allow developers to specify whether they want txs to be sent as an atomicBatch

how does this signal about atomicBatch?

my note above is more towards how we'll handle it in the future once we start using the deployed boop spec 🙂

currently the only expected capability is a specified boopPaymaster, we'll support atomic batching as well

ultraviolet10 · 2025-02-19T12:02:11Z

apps/iframe/src/requests/approved.ts

+        case "wallet_showCallsStatus": {
+            const _boopBundleId = request.payload.params?.[0]
+            return undefined
+        }


this request handler doesn't particularly do anything: context here

relevant docs: https://www.eip5792.xyz/reference/showCallsStatus

ultraviolet10 · 2025-02-19T12:06:23Z

apps/iframe/src/requests/permissionless.ts

+                if (!hash) {
+                    throw new InternalRpcError(new Error("Transaction hash is missing."))
+                }
+                const smartAccountClient = (await getSmartAccountClient()) as ExtendedSmartAccountClient


here, the docs suggest: "the method only returns a subset of the fields that eth_getTransactionReceipt returns"

we switch this up with the return type from -
smartAccountClient.waitForUserOperationReceipt
since that's what we primarily handle here and not 1559 txs

ultraviolet10 · 2025-02-19T12:07:04Z

apps/iframe/src/routes/request.lazy.tsx

            return <HappyUseAbi {...props} />
        case HappyMethodNames.REQUEST_SESSION_KEY:
            return <HappyRequestSessionKey {...props} />
+        case "wallet_sendCalls":


placeholder!

what do you mean placeholder here 🧐

ultraviolet10 · 2025-02-19T12:08:10Z

apps/iframe/src/state/walletClient.ts

    if (!user?.controllingAddress || !provider || !transport) return

-    return createWalletClient({ account: user.controllingAddress, transport })
+    return createWalletClient({ account: user.controllingAddress, transport }).extend(eip5792Actions())


this will be needed in the popup for when the user calls wallet_showCallsStatus

discussion context: https://happychaindevs.slack.com/archives/C084LLRJF5M/p1739780751376089?thread_ts=1739542573.757479&cid=C084LLRJF5M

ultraviolet10 · 2025-02-19T12:09:07Z

demos/react/src/App.tsx

+                id: sends,
+            })
+
+            console.log({ status, receipts })


this would really benefit from the changes from #380 😄

not-reed · 2025-02-27T17:10:29Z

apps/iframe/src/routes/request.lazy.tsx

            return <HappyUseAbi {...props} />
        case HappyMethodNames.REQUEST_SESSION_KEY:
            return <HappyRequestSessionKey {...props} />
+        case "wallet_sendCalls":


what do you mean placeholder here 🧐

not-reed · 2025-02-27T17:12:10Z

apps/iframe/src/components/requests/WalletSendCalls.tsx

+    console.log("param", { method, params })
+    // TODO only for testiog


component is only for testing, or log is? use our logger.debug :)

not-reed · 2025-02-27T17:13:22Z

apps/iframe/src/constants/requestLabels.ts

    wallet_watchAsset: "Watch Asset",
    [HappyMethodNames.USE_ABI]: "Record ABI",
    [HappyMethodNames.REQUEST_SESSION_KEY]: "Approve Session Key",
+    wallet_sendCalls: "Send Calls",


group this alphabetically with the other wallet_ calls

not-reed · 2025-02-27T17:16:41Z

apps/iframe/src/requests/approved.ts

+            const callsData = request.payload.params?.[0]
+            if (!callsData) throw new InternalRpcError(new Error("Invalid request payload"))
+
+            if (user.address !== callsData.from) {


is all callsData.from assumed to be the same user?

Suggested change

if (user.address !== callsData.from) {

if (request.payload.params.some(callsData => callsData.from !== user.address)) {

not-reed · 2025-02-27T17:19:06Z

apps/iframe/src/requests/approved.ts

+            const callsData = request.payload.params?.[0]
+            if (!callsData) throw new InternalRpcError(new Error("Invalid request payload"))


there can be multiple callsData right?

this is a good point, we should validate params is actually the shape we expect, elsewhere we are just assuming it it, but its probably a good practice to validate this. maybe lets use zod?

not-reed · 2025-02-27T17:38:59Z

apps/iframe/src/requests/approved.ts

+                })
+            }
+
+            return userOpHash


it also says its a call identifier to check the status of the call, and not needed to be a transactionHash/userOp hash... maybe its a hash of all included userOps? just using the last one feels a bit arbitrary to me 🤔

if its an atomicBatch as mentioned before, then this would just return a single userOp anyways right? but if its not an atomicBatch, then only having the last userOp seems not ideal as a lookup key

not-reed · 2025-02-27T17:39:32Z

apps/iframe/src/requests/approved.ts

+        }
+
+        case "wallet_showCallsStatus": {
+            const _boopBundleId = request.payload.params?.[0]


do you even need this line 🧐

not really, just added it there to show it's presence?

I'll remove it 👍

not-reed · 2025-02-27T17:44:42Z

apps/iframe/src/requests/modules/boop-batcher/helpers.ts

+                data: log.data as Hex,
+                topics: log.topics as Hex[],
+            })),
+            status: (success ? "0x1" : "0x0") as Hex,


are these backwards?

follows the spec here: https://eips.ethereum.org/EIPS/eip-5792#wallet_getcallsstatus

not-reed · 2025-02-27T17:50:44Z

demos/react/src/App.tsx

        () => user?.address && createWalletClient({ account: user.address, transport: custom(provider!) }),
        [user, provider],
-    )
+    )?.extend(eip5792Actions())


shouldn't this be inside useMemo on createWalletClient?

not-reed · 2025-02-27T17:51:28Z

demos/react/src/App.tsx

+                id: sends,
+            })
+
+            console.log({ status, receipts })


ultraviolet10 · 2025-03-14T15:24:20Z

closing, replicated in graphite stack here

ultraviolet10 changed the title ~~wip: eip5792 rpc call implementations [skip ci]~~ Implement EIP-5792 functionalities Feb 19, 2025

ultraviolet10 requested review from naomiHauret and not-reed February 19, 2025 10:46

ultraviolet10 self-assigned this Feb 19, 2025

ultraviolet10 added the draft Not ready for review label Feb 19, 2025 — with Graphite App

ultraviolet10 marked this pull request as ready for review February 19, 2025 10:46

ultraviolet10 commented Feb 19, 2025

View reviewed changes

ultraviolet10 added reviewing-1 Ready for, or undergoing first-line review and removed draft Not ready for review labels Feb 19, 2025

not-reed reviewed Feb 27, 2025

View reviewed changes

ultraviolet10 force-pushed the aritra/eip-5792 branch 3 times, most recently from ea3cb19 to 4cf021c Compare March 7, 2025 14:42

ultraviolet10 added 7 commits March 14, 2025 11:16

wip: eip5792 rpc call implementations [skip ci]

545e0e5

feat: sendCalls request handler

180a615

feat: getCallsStatus request handler [skip ci]

c0eb36e

demo: add client calls to demo for requests

710c05e

fix: improve wallet_getCallsStatus handler for user operations [skip ci]

fa36a91

refactor: misc [skip ci]

a62cda6

misc fixes

253c9a6

ultraviolet10 added 2 commits March 14, 2025 11:16

fix: extend type for wallet client

6050284

pr cleanup for chunks

9b310f1

ultraviolet10 force-pushed the aritra/eip-5792 branch from 4cf021c to 9b310f1 Compare March 14, 2025 06:18

ultraviolet10 mentioned this pull request Mar 14, 2025

wip: eip5792 rpc call implementations [skip ci] #523

Closed

11 tasks

ultraviolet10 closed this Mar 14, 2025

norswap deleted the aritra/eip-5792 branch July 24, 2025 15:18

		console.log("param", { method, params })
		// TODO only for testiog

	if (user.address !== callsData.from) {
	if (request.payload.params.some(callsData => callsData.from !== user.address)) {

		const callsData = request.payload.params?.[0]
		if (!callsData) throw new InternalRpcError(new Error("Invalid request payload"))

Conversation

ultraviolet10 commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked Issues

Description

Checklist

Basics

Correctness

Architecture & Documentation

Uh oh!

ultraviolet10 commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying happychain with Cloudflare Pages

Uh oh!

linear bot commented Feb 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ultraviolet10 Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ultraviolet10 Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ultraviolet10 commented Mar 14, 2025

Uh oh!

Reviewers

ultraviolet10 commented Feb 19, 2025 •

edited

Loading

ultraviolet10 commented Feb 19, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 19, 2025 •

edited

Loading

ultraviolet10 Feb 19, 2025 •

edited

Loading

ultraviolet10 Feb 19, 2025 •

edited

Loading