Skip to content

fix(tools): harden asynchronous JDBC downloads - #34

Open
HandSonic wants to merge 107 commits into
mainfrom
fix/jdbc-download-daemon-threads
Open

HandSonic wants to merge 107 commits into
mainfrom
fix/jdbc-download-daemon-threads

Conversation

@HandSonic

@HandSonic HandSonic commented Aug 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • run asynchronous JDBC download workers as named daemon threads
  • publish downloads through same-directory temporary files and atomic replacement
  • preserve previously published drivers on failed refreshes
  • clean stale partial files without touching active downloads

Validation

  • JdbcJarUtilsTest: 9/9 passed
  • tools module suite: 72/72 passed
  • tools module and dependencies packaged successfully
  • three adversarial review rounds: no blocking findings after follow-up fixes
  • git diff --check passed

Upstream issue: OtterMind#2684

Latest-main verification (2026-09-04)

  • Rebased onto 144a04ee2; full tools suite passed (73 tests).n- The Linux CI-only race was traced to OkHttp temporarily renaming a daemon worker during its callback. The test now separates stable factory naming from actual callback daemon status; the focused suite passed 10 consecutive runs before the full suite.n- Combined with fix(jdbc): use configured driver download URLs OtterMind/Chat2DB#2695 using a semantic conflict resolution; full combined tools suite passed (76 tests), covering daemon workers, atomic publication, and dynamic runtime paths.

@HandSonic
HandSonic force-pushed the fix/jdbc-download-daemon-threads branch 2 times, most recently from f9b8490 to f4e2c03 Compare August 12, 2026 17:34
@HandSonic
HandSonic force-pushed the fix/jdbc-download-daemon-threads branch from f4e2c03 to 7d28b09 Compare August 19, 2026 20:16
Aias00 and others added 25 commits August 21, 2026 02:36
Add `visible` field to TableIndex domain model, read the `Visible` column
from SHOW INDEXES in MySQL metadata, generate INVISIBLE keyword in index
DDL, and add buildAlterIndexVisibility for ALTER INDEX syntax.

Frontend: add a "Visible" column to the index editor with a
VISIBLE/INVISIBLE toggle, disabled for primary keys, gated to MySQL only.

Test fixtures: init.sql, grants.sql, cleanup.sql, README.md under
script/test-fixtures/mysql/MYSQL-OBJ-006/.

Closes OtterMind#2574
Replace hardcoded INVISIBLE, ALTER INDEX strings with constants
SQL_INVISIBLE and SQL_ALTER_INDEX from MysqlSqlConstants.
…ABLE

buildAlterIndexVisibility was dead code: a visibility-only change fell
through to DROP+ADD, rebuilding the whole index. ALTER TABLE now emits
ALTER INDEX ... VISIBLE/INVISIBLE when the modified index differs from
the stored one only in visibility (and is not the primary key), and
falls back to the rebuild path otherwise.
Add `visible` field to TableColumn domain model, detect "INVISIBLE"
from the EXTRA column in information_schema, and generate the INVISIBLE
keyword in column DDL via MysqlColumnTypeEnum.

Frontend: add a "Visible" column to the column editor with a
VISIBLE/INVISIBLE toggle, gated to MySQL only.

Test fixtures: init.sql, grants.sql, cleanup.sql, README.md under
script/test-fixtures/mysql/MYSQL-OBJ-003/.

Closes OtterMind#2571
Replace hardcoded INVISIBLE string with SQL_INVISIBLE constant
from MysqlMetaDataConstants in MysqlColumnTypeEnum.
MySQL column grammar requires VISIBLE/INVISIBLE before the COMMENT
clause; the previous order produced ERROR 1064 for invisible columns
that carry a comment.
Adds a read-only Active Transactions view for the datasource node:
- Lists innodb_trx joined with processlist: transaction ID, state,
  start time, age, isolation level, rows locked/modified, thread ID,
  user, host, database, and current SQL.
- Works on MySQL 5.7 and 8.0; SQL text is null without PROCESS and
  surfaced as an explicit unavailable state instead of a blank value.
- New tree menu entry with a refreshable table dialog, i18n in all five
  locales, and MYSQL-OPS-002 fixtures (admin vs limited accounts).
…tolerant fallback

1. Add `resolveShellCandidates` method to return available shell candidates based on the operating system
2. Modify `create` method to sequentially try starting shells from the candidate list, automatically falling back to the next on failure
3. Add unit tests to verify shell candidate resolution and exception scenarios
4. Add compatibility handling for scenarios where enterprise security software blocks the default shell
…igurable default shell and improved shell candidate resolution

- Introduce DEFAULT_SHELL_PROPERTY configuration property for setting the default shell
- Add processFactory factory method to support custom process creation logic
- Refactor create method to accept pre-resolved shell candidate list
- Extract PtyProcess startup logic into a separate startProcess method
- Add proper argument configuration for PowerShell and CMD commands (-NoLogo, -NoExit, -Command, etc.)
- Improve shell candidate resolution order on Windows (pwsh → PowerShell → cmd)
- Add support for zsh and bash colored prompts
- Add test helper methods to reset factory and event publisher state
- Add comprehensive unit tests covering shell configuration and failover scenarios
- Change inner classes and enums to public to support external access
- Add command parser interface to support custom command lookup logic
- route DM SQL through the DM command executor
- add dedicated DM lexer and parser support
- retrieve execution plans through DmdbConnection.getExplainInfo
- preserve SQL type, metrics, streaming, and error behavior
- cover explicit EXPLAIN, Explain actions, cancellation, and driver isolation

Fixes OtterMind#2762
openai0229 and others added 25 commits September 2, 2026 14:55
refactor(terminal): refactor terminal shell startup logic with fault-tolerant fallback
…-column-2571

feat(mysql): invisible column management for MySQL 8.0.23+
…edit-actions

fix(result): stabilize sorting and edit actions
…active-transaction-2595

# Conflicts:
#	chat2db-community-client/package.json
…-theme-accent

fix(workspace): smooth panel resizing and restore theme accents
…ansaction-2595

feat(mysql): active InnoDB transaction inspection (OtterMind#2595)
…-expiration

fix(redis): persist no-expiration TTL updates
# Conflicts:
#	chat2db-community-client/package.json
#	chat2db-community-client/src/pages/main/workspace/components/WorkspaceExtend/GlobalExtendComponents/accountGrantsRequest.test.ts
#	chat2db-community-client/src/pages/main/workspace/components/WorkspaceExtend/GlobalExtendComponents/accountGrantsRequest.ts
…atest-request

fix(frontend): ignore stale account grants
@HandSonic
HandSonic force-pushed the fix/jdbc-download-daemon-threads branch from 7d28b09 to 61f6bf9 Compare September 3, 2026 22:55
@HandSonic
HandSonic force-pushed the fix/jdbc-download-daemon-threads branch from 61f6bf9 to 31b6482 Compare September 3, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants