Development: 1.6.0 #3141
Open
Development: 1.6.0 #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 9, 2020 14:07
…ct call can exit immediately
…fore changing the flag. Otherwise it would confuse the closing function when used on a connected socket
…ges by google test
… dead code (this solution deadlocks)
added 18 commits
March 12, 2025 16:23
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
srtcore/utilities.h
Outdated
Comment on lines
452
to
468
| /* | ||
| const T& operator[](int index) const | ||
| { | ||
| if (index < 0 || static_cast<size_t>(index) >= m_size) | ||
| throw_invalid_index(index); | ||
|
|
||
| return m_entries[index]; | ||
| } | ||
|
|
||
| T& operator[](int index) | ||
| { | ||
| if (index < 0 || static_cast<size_t>(index) >= m_size) | ||
| throw_invalid_index(index); | ||
|
|
||
| return m_entries[index]; | ||
| } | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 1 day ago
To fix the problem, we should remove the commented-out code block from lines 452 to 468. This will eliminate the distraction and potential confusion caused by the presence of commented-out code. The existing functionality of the operator[] functions will remain unchanged.
Suggested changeset
1
srtcore/utilities.h
| @@ -451,19 +451,3 @@ | ||
|
|
||
| /* | ||
| const T& operator[](int index) const | ||
| { | ||
| if (index < 0 || static_cast<size_t>(index) >= m_size) | ||
| throw_invalid_index(index); | ||
|
|
||
| return m_entries[index]; | ||
| } | ||
|
|
||
| T& operator[](int index) | ||
| { | ||
| if (index < 0 || static_cast<size_t>(index) >= m_size) | ||
| throw_invalid_index(index); | ||
|
|
||
| return m_entries[index]; | ||
| } | ||
| */ | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
added 8 commits
March 13, 2025 15:02
6 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR for complete review and CI. Assigned PRs:
OTHERS: