Fixed correct includes for std::div

Haivision · ethouris · Mar 5, 2024 · Mar 5, 2024 · May 24, 2024 · May 24, 2024
commit 193fe39d3010ecf8eb2b3209eee5f8129220eaca
diff --git a/srtcore/sfmt.h b/srtcore/sfmt.h
@@ -15,7 +15,8 @@
 
 #include <cstdio>
 #include <cstring>
-#include <cmath>
+#include <cmath> // std::abs
+#include <cstdlib> // std::div
 #include <string>
 #include <vector>
 #include <list>

diff --git a/srtcore/utilities.h b/srtcore/utilities.h
    }
    return os.str();

    /* OLD VERSION

    //char buf[256];
    using namespace std;

    ostringstream os;

    // I know, it's funny to use sprintf and ostringstream simultaneously,
    // but " %02X" in iostream is: << " " << hex << uppercase << setw(2) << setfill('0') << VALUE << setw(1)
    // Too noisy. OTOH ostringstream solves the problem of memory allocation
    // for a string of unpredictable size.
    //sprintf(buf, "%02X", int(bytes[0]));

    os.fill('0');
    os.width(2);
    os.setf(ios::basefield, ios::hex);
    os.setf(ios::uppercase);

    //os << buf;
    os << int(bytes[0]);


    for (size_t i = 1; i < size; ++i)
    {
        //sprintf(buf, " %02X", int(bytes[i]));
        //os << buf;
        os << int(bytes[i]);
    }
    return os.str();
    */
 }
	}
	return os.str();

	/* OLD VERSION

	//char buf[256];
	using namespace std;

	ostringstream os;

	// I know, it's funny to use sprintf and ostringstream simultaneously,
	// but " %02X" in iostream is: << " " << hex << uppercase << setw(2) << setfill('0') << VALUE << setw(1)
	// Too noisy. OTOH ostringstream solves the problem of memory allocation
	// for a string of unpredictable size.
	//sprintf(buf, "%02X", int(bytes[0]));

	os.fill('0');
	os.width(2);
	os.setf(ios::basefield, ios::hex);
	os.setf(ios::uppercase);

	//os << buf;
	os << int(bytes[0]);


	for (size_t i = 1; i < size; ++i)
	{
	//sprintf(buf, " %02X", int(bytes[i]));
	//os << buf;
	os << int(bytes[i]);
	}
	return os.str();
	*/
Check notice Code scanning / CodeQL Commented-out code Note This comment appears to contain commented-out code.
	}