-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added balancing groups and common group receiver #2885
Draft
ethouris
wants to merge
100
commits into
Haivision:master
Choose a base branch
from
ethouris:dev-add-group-balancing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,798
−995
Draft
Changes from 1 commit
Commits
Show all changes
100 commits
Select commit
Hold shift + click to select a range
463085c
First trial version
7fbca8a
Completed balancing code (compiled, not tested)
6602b15
Updated to latest master
29735ff
First version compiled with new recv buffer. Nothing tested.
3549bb8
Merged last upstream. Fixed compiling against ENABLE_NEW_RCVBUFFER
027072a
Fixed referring to buffer pointer in the socket
7a5853b
Fixed some bux during the first run
44803f2
Merge remote-tracking branch 'origin/master' into dev-add-group-balan…
6862b97
Fixed getting group status with the reading function
087b8db
Fixed bux in receiver buffer. Fixed handshake resource creation order…
b5d95d2
Added a workaround to read-ready check for a group-member socket
f03b09e
Added specific algorithm for tracking group loss for balancing groups
38510ab
Fixed broken release build
ethouris 23dec40
Fixed bug: wrong loss range found in the buffer. Added broadcast grou…
ethouris e739133
Added common group losses handling
92639ad
Implemented receiver loss management for new bonding
ethouris 2de148e
Cosmetics
ethouris 047f126
Merge branch 'master' into dev-add-group-balancing
ethouris d07e71a
Minor bugfixes. Some line reordering and comment fixes
ethouris 496e6a7
Exported fragment to a separate function
dbc3729
Fixed one deadlock. Added verification in snd-loss-removal procedure
b514108
Added handling of balancing group for srt-test-live. Fixed permissions.
ethouris 03214ff
Applied changes from PR 2467-before merging
a1bb540
Fixed balancing mode sending. Fixed loss list selective extraction. A…
1f8faac
Improved and fixed balancing loss detection
ethouris faf9bec
Merged against latest master
96e92dd
Adjusted to the latest changes in the group branch, per changes in ma…
bdc6fff
Updated and post-fixed
deeaf05
Some cosmetic fixes after the update
a68d5cf
Updated for latest master
d2d1c90
Merge branch 'master' into dev-processdata-refax
89e927f
Added lacking fix for AEAD
a56c84d
Fixed: block static variable that might be unused when no logging (tr…
974a6ed
Merged with master (changes for AEAD)
0168c5e
Fixed after PR comments
870509f
Renamed getPacketPTS. Moved call to obtain PTS under belated condition
c103433
Updated taking pts for stats and logs only where needed. Added more e…
b3f768f
Improved logging for the receiver side
ethouris e979a68
Updated from master and post-fixed
a5d0e73
Merge remote-tracking branch 'refs/remotes/ethouris/dev-add-group-bal…
b15876e
Added some comments regarding the new TSBPD triggering rules
9f5174c
Merge branch 'dev-processdata-refax' into dev-refax-buffer-tsbpd-trig…
652e35d
Applied changes for improved TSBPD and receiver buffer
37ec000
Updated to the latest master and fixed
6295cb9
Updated and fixed
36c1f67
Updated usage of shortcuts and new names
1fbd754
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
478ca41
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
8335cbe
Fixed some logs formatting
ethouris e217b7d
Updated to latest upstream
df46c57
Updated to latest upstream
251c9c5
Updated, part 1. Not tested (only UT)
4b39b7b
Merge branch 'master' into dev-add-group-balancing
1df7e40
Updated and fixed
631adb0
Some cosmetics and updates from upstream
26d11de
Updated to latest upstream
db18435
Fixed atomic operator bug (reported by gcc-11)
9f7db49
Fixed: for backup link sync use the common group buffer start sequence
35450ca
Fixed deadlock on 2L locked GroupLock. Fixed crash when discarding a …
a826e3c
Trial fix for the rogue ACK in backup groups
b116838
Some cosmetic log fixes
ethouris eaf51e4
Updated to latest upstream
ethouris 0b515e8
Updated
f636ce7
Updated and fixed
dc2dcdf
Updated lock info in the comment
ae914e5
Merged and stabilized
519cb7e
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
4bb7b47
Added mutex spec to a function
d179878
Added more thread check entries
94fb676
Updated to latest upstream
8ad69ed
Fixed a suggested uninitialized variable
bbced79
Renamed eclipsed variable
5136ca2
Added doxy description for some functions. Applied NonOrder in names …
f6e0271
Removed wrong fix. Fixed C++11 style initialization of PacketInfo
072a8c4
Refax: CRcvBuffer extracted some parts of insert() to separate functions
4302615
Updated and fixed
1830e3a
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
7bdd82c
Merged and post-fixed
432b0c7
Fixed some problems around macros that caused build breaks
f416392
Fixed gcc extension causing BB on Windows
5b99754
Fixed some build breaks reported by CI
328c359
Fixed C++03 incompat case
283021e
Apply suggestions from code review
ethouris b969a83
Remaining post-review fixes
df237d6
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
d8f485a
Merge branch 'master' into dev-refax-buffer-tsbpd-triggers
d9f079a
Turned integer-based values to strong types. CHECKPOINT: tests passed
ab469d6
Fixed previous problems with receiver buffer
a2b1b44
First working version with end/drop as offset
ethouris ff16e68
Blocked development support types and fixed the test
1f6ac3d
Updated to latest upstream
fa70fda
Merged changes
1bf93ff
Cleanup of the commented-out code
f4f22ba
Cleaning up other temporary development entries
2e182a8
Updated with latest changes in receiver buffer. NOT TESTED, one IPE i…
0a88fdf
Updated and fixed
74a27ed
Updated and fixed
cb00cce
Added option to disable test discovery (off by default)
5bc71e9
BUGFIX: the buffer info extraction function wasn't mutex-protected
498d980
Updated and fixed
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Fixed some build breaks reported by CI
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return 0; | ||
} | ||
//const bool canReadInOrder = m_iFirstNonreadPos != m_iStartPos; | ||
Check notice Code scanning / CodeQL Commented-out code Note
This comment appears to contain commented-out code.
|
||
const int readPos = canReadInOrder ? m_iStartPos : m_iFirstNonOrderMsgPos; | ||
const bool isReadingFromStart = (readPos == m_iStartPos); // Indicates if the m_iStartPos can be changed | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return m_pRcvBuffer->getPktTsbPdTime(usPktTimestamp); | ||
} | ||
/* | ||
int32_t getOldestRcvSeqNo() const | ||
{ | ||
return m_pRcvBuffer->getStartSeqNo(); | ||
} | ||
*/ | ||
Check notice Code scanning / CodeQL Commented-out code Note
This comment appears to contain commented-out code.
|
||
// Property accessors | ||
SRTU_PROPERTY_RW_CHAIN(CUDTGroup, SRTSOCKET, id, m_GroupID); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning