Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproduce test conditions #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reproduce test conditions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- uses: ./
- uses: reviewdog/action-hadolint@v1
with:
reporter: github-pr-review
fail_level: error
filter_mode: diff_context
exclude: Dockerfile.dockerignore
2 changes: 1 addition & 1 deletion testdata/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM ubuntu

RUN apt-get install -y jq

Check notice on line 3 in testdata/Dockerfile

View workflow job for this annotation

GitHub Actions / hadolint

[hadolint] testdata/Dockerfile#L3 <DL3015>(https://github.com/hadolint/hadolint/wiki/DL3015) 

Avoid additional packages by specifying `--no-install-recommends`
Raw output 
message:"Avoid additional packages by specifying `--no-install-recommends`" location:{path:"testdata/Dockerfile" range:{start:{line:3 column:1}}} severity:INFO source:{name:"hadolint" url:"https://github.com/hadolint/hadolint"} code:{value:"DL3015" url:"https://github.com/hadolint/hadolint/wiki/DL3015"}

Check warning on line 3 in testdata/Dockerfile

View workflow job for this annotation

GitHub Actions / hadolint

[hadolint] testdata/Dockerfile#L3 <DL3008>(https://github.com/hadolint/hadolint/wiki/DL3008) 

Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Raw output 
message:"Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`" location:{path:"testdata/Dockerfile" range:{start:{line:3 column:1}}} severity:WARNING source:{name:"hadolint" url:"https://github.com/hadolint/hadolint"} code:{value:"DL3008" url:"https://github.com/hadolint/hadolint/wiki/DL3008"}

RUN LANGUAGE= nl

Check notice on line 5 in testdata/Dockerfile

View workflow job for this annotation

GitHub Actions / hadolint

[hadolint] testdata/Dockerfile#L5 <DL3059>(https://github.com/hadolint/hadolint/wiki/DL3059) 

Multiple consecutive `RUN` instructions. Consider consolidation.
Raw output 
message:"Multiple consecutive `RUN` instructions. Consider consolidation." location:{path:"testdata/Dockerfile" range:{start:{line:5 column:1}}} severity:INFO source:{name:"hadolint" url:"https://github.com/hadolint/hadolint"} code:{value:"DL3059" url:"https://github.com/hadolint/hadolint/wiki/DL3059"}

Check warning on line 5 in testdata/Dockerfile

View workflow job for this annotation

GitHub Actions / hadolint

[hadolint] testdata/Dockerfile#L5 <SC1007>(https://github.com/koalaman/shellcheck/wiki/SC1007) 

Remove space after = if trying to assign a value (for empty string, use var='' ... ).
Raw output 
message:"Remove space after = if trying to assign a value (for empty string, use var='' ... )." location:{path:"testdata/Dockerfile" range:{start:{line:5 column:1}}} severity:WARNING source:{name:"hadolint" url:"https://github.com/hadolint/hadolint"} code:{value:"SC1007" url:"https://github.com/koalaman/shellcheck/wiki/SC1007"}
RUN cd /tmp && echo "hello!"
RUN cd /tmp && echo "helloooooo!"

Check warning on line 6 in testdata/Dockerfile

View workflow job for this annotation

GitHub Actions / hadolint

[hadolint] testdata/Dockerfile#L6 <DL3003>(https://github.com/hadolint/hadolint/wiki/DL3003) 

Use WORKDIR to switch to a directory
Raw output 
message:"Use WORKDIR to switch to a directory" location:{path:"testdata/Dockerfile" range:{start:{line:6 column:1}}} severity:WARNING source:{name:"hadolint" url:"https://github.com/hadolint/hadolint"} code:{value:"DL3003" url:"https://github.com/hadolint/hadolint/wiki/DL3003"}
Loading