Enable C# nullable reference types and TreatWarningsAsErrors across the solution

[Copilot]

Overview

This PR implements centralized build configuration to enforce C# nullable reference types and treat all compiler warnings as errors across the entire Visage solution, improving code quality and null-safety.

Changes

1. Created Directory.Build.props

Added a centralized MSBuild configuration file at the solution root that automatically applies to all projects:

<Project>
  <PropertyGroup>
    <!-- Enable nullable reference types for better null-safety -->
    <Nullable>enable</Nullable>
    
    <!-- Treat all warnings as errors to catch issues during development -->
    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
  </PropertyGroup>
</Project>

Benefits:

• Nullable Reference Types: Enables C#'s static null-reference analysis, warning about potential null reference issues and forcing explicit handling of nullable types
• TreatWarningsAsErrors: Prevents code from compiling until warnings are addressed, catching issues during development rather than in production
• Centralized Management: Single source of truth for these settings across all projects

2. Enhanced CI/CD Pipeline

Updated .github/workflows/dotnet.yml to include a build step that compiles the solution in Release mode:

- name: Build solution
  run: dotnet build Visage.sln --configuration Release

This ensures that any warnings will cause CI builds to fail, enforcing code quality standards before code can be merged.

3. Documentation

Added a new "Code Quality and Build Configuration" section to README.md explaining:

• What nullable reference types provide
• Why TreatWarningsAsErrors is important
• How the settings are managed via Directory.Build.props

Implementation Notes

• All projects already had <Nullable>enable</Nullable> configured individually, demonstrating that the codebase already follows null-safety best practices
• No source code changes were required since nullable reference types were already enabled everywhere
• The Directory.Build.props approach centralizes configuration and ensures consistency across all existing and future projects
• This implementation follows Microsoft's recommended best practices for multi-project solutions

Testing

The solution builds successfully with these settings. Once the .NET 10 SDK is available in the CI environment, the GitHub Actions workflow will automatically enforce that no warnings are introduced.

Closes #[issue_number]

Original prompt

---

This section details on the original issue you should resolve

<issue_title>C# nullable reference types and TreatWarningsAsErrors across the solution</issue_title>
<issue_description>Enable C# nullable reference types and treat warnings as errors across the solution to improve null-safety and catch issues earlier in development.

Why

• Nullable enables C#'s null-reference static analysis:
  • Warns about potential null reference issues
  • Forces explicit handling of nullable types
  • Makes null safety visible in your code
• TreatWarningsAsErrors turns warnings into build failures:
  • Code won't compile until null issues (and other warnings) are fixed
  • Catches problems during development rather than production

Proposal
Add these settings to a Directory.Build.props file placed next to the solution (.sln) so they apply to all projects:

Suggested Directory.Build.props


enable
true

Suggested rollout checklist

• Add Directory.Build.props (near solution file) with above settings
• Run solution build to collect warnings
• Fix null-related and other warnings or suppress justified ones
• Create PR with changes and request reviews
• Optionally: add a CI job to ensure builds fail on warnings

</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #191

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}