Brussels | ITP-2025-1 | Preeti Tyagi | Week 6 | Sprint 3 Coursework/sprint-3-practice-tdd #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
completed the code using for loop
made changes as required
completed the code
completed the code for different cases
made correction
completed the cases
MustafaBora
requested changes
Jan 7, 2026
| @@ -1,5 +1,11 @@ | |||
| function getOrdinalNumber(num) { | |||
| if (num > 1 || num < 1) { | |||
Author
There was a problem hiding this comment.
I have added implementation in the code. The code is now updated @MustafaBora
There was a problem hiding this comment.
I see you have solved the question on get-ordinal-number.test.js.
Test file should contain only the tests, and this file should contain the solution
There was a problem hiding this comment.
tests like:
test("should return '3rd' for 3", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
});
test("should return '11th' for 11", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
});
test("should return '13th' for 13", () => {
expect(getOrdinalNumber(13)).toEqual("13th");
});
implementation completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Change list
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.