Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented report page #31

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Implemented report page #31

merged 1 commit into from
Apr 28, 2024

Conversation

rumana-aafrin
Copy link
Collaborator

Description

This PR is about fixing some syntax errors in the report page

How to test?

http://localhost:3000/reportPage

Checklist

  • I have performed a self-review of my own code
  • I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
  • I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
  • I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
  • This PR is ready to be merged and not breaking any other functionality

@rumana-aafrin rumana-aafrin requested a review from a team as a code owner April 25, 2024 19:55
@@ -5,7 +5,7 @@ import Dashboard from './containers/Dashboard/Dashboard';
import { LandingPageContainer } from './containers/LandingPage/LandingPage';
import { CheckinQuestions } from './containers/QuestionPage/CheckinQuestions';
import { TeamIdContextProvider } from './hooks/contextHook';
import { ReportPage } from './containers/ReportPage/ReportPage';
import ReportPage from './containers/ReportPage/ReportPage';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to be consistent with the other ones, though that's a minor point.

@rumana-aafrin rumana-aafrin merged commit 5d230c1 into main Apr 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants