fix(payments): credit gems before marking IAP receipt consumed & add retry #15459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…retry Previously we marked the IAP receipt consumed in the DB before attempting to credit gems. If crediting failed (e.g. transient DB/network error), the token was "burned" and the Android/iOS client would consume it on their side, making retries impossible and causing players to pay without receiving gems. This change: - Introduces "safeBuySkuItem" in googlePlay.js/apple.js with a 3-attempt exponential-backoff wrapper around payments.buySkuItem. - Swaps the order in verifyPurchase/noRenewSubscribe: first call 'safeBuySkuItem', then 'IapPurchaseReceipt.create' only on success. - Ensures any failure bubbles up before the receipt is marked consumed. Now purchases are retried on transient failures and receipts are only burned once delivery succeeds.
|
Cleaned up various lint issues for ya ... not entirely sure what to make of the Edit: possibly need to use |
|
Going to close this in lieu of of a cleaner/simpler approach on another upcoming PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we marked the IAP receipt consumed in the DB before attempting
to credit gems. If crediting failed (e.g. transient DB/network error),
the token was "burned" and the Android/iOS client would consume it on
their side, making retries impossible and causing players to pay without
receiving gems.
This change:
exponential-backoff wrapper around payments.buySkuItem.
'safeBuySkuItem', then 'IapPurchaseReceipt.create' only on success.
Now purchases are retried on transient failures and receipts are only
burned once delivery succeeds.