-
Notifications
You must be signed in to change notification settings - Fork 2
feat/#30: Meeting 생성 api 구현 완료 #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- 정적 팩토리 메서드를 활용한 필드 강제화 - agendaResult 추가 - AllArgsConstructor, Builder 어노테이션 삭제
- WORKSPACE_NOT_FOUND
2ghrms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
| String agendaResult = "안건지 요약 - 미구현"; | ||
|
|
||
|
|
||
| Meetings newMeetings = Meetings.createInitialMeeting( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builder사용해주시면 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DDD설계 원칙에 따라 유연성 있는 builder패턴을 사용하지 않고
정적팩토리메서드를 통해 Meeting 객체가 생성될 때 필수 필드들을 강제하고, 도메인 객체 자체가 자신의 생성규칙을 책임지며 초기상태 회의를 생성한다는 의도를 드러내어줄 수 있습니다!
#️⃣연관된 이슈
📝작업 내용
🔎코드 설명(스크린샷(선택))
💬고민사항 및 리뷰 요구사항 (Optional)
비고 (Optional)