Repository navigation
Conversation
MLX5 moves QPs to RTR/RTS through mlx5dv.modify_qp(), which takes the GID type as an explicit argument because userspace builds the QP address vector itself. The generic ibv_modify_qp() path did not need this: the kernel derived the RoCE version from the GID entry that sgid_index points at. select_gid_index() only assigned nic.gid_type on the automatic-probe path, so the ROCSHMEM_IB_GID_INDEX override updated nic.gid_index and nic.gid but left nic.gid_type at the value the probe had picked. The probe prefers RoCEv2, so forcing a RoCEv1 index such as GID 0 built an address vector as RoCEv2 while sgid_index selected a RoCEv1 GID, and the NIC rejected the transition with EREMOTEIO (121) from modify_qps_init_to_rtr(). Take gid_type from the GID table entry of the forced index so it always matches sgid_index.
AI Review审查尚未完整完成,无法给出整体结论;当前没有可发布的已确认问题,不代表代码没有问题。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLX5 moves QPs to RTR/RTS through mlx5dv.modify_qp(), which takes the GID type as an explicit argument because userspace builds the QP address vector itself. The generic ibv_modify_qp() path did not need this: the kernel derived the RoCE version from the GID entry that sgid_index points at.
select_gid_index() only assigned nic.gid_type on the automatic-probe path, so the ROCSHMEM_IB_GID_INDEX override updated nic.gid_index and nic.gid but left nic.gid_type at the value the probe had picked. The probe prefers RoCEv2, so forcing a RoCEv1 index such as GID 0 built an address vector as RoCEv2 while sgid_index selected a RoCEv1 GID, and the NIC rejected the transition with EREMOTEIO (121) from modify_qps_init_to_rtr().
Take gid_type from the GID table entry of the forced index so it always matches sgid_index.