Repository navigation
Conversation
Migrate codebase from DCU to HCU terminology and fix a bug in the GEMM stress test diagnostic pipeline where Mean values were silently reported as 0 on non-zero subprocess exit. Core changes: - Rename terminology, APIs, and deployment manifests from DCU to HCU across pkg/, samples/, deployment/, and router layer - Update k8s manifest and Docker deployment scripts for HCU environment Bug fix — GEMM diagnostic result loss (pkg/dcgm/gemmperf.go): - gemmPerf binary always runs on all devices per invocation; restructure loop from (device × gemm-type) to (gemm-type only), parsing per-device results from a single shared log file — eliminates redundant N_devices invocations and resolves log-file mismatch on multi-device systems - Remove unused devInd parameter from runGemmTest() - parseGemmLog: return explicit error when target HCU mean is absent in log instead of silently returning 0 - runTargetStressTestWithResult: always attempt log parse even when subprocess exits non-zero; preserve valid mean and propagate run error into GemmTestResult.Error field - Add Error string field to GemmTestResult to carry per-entry detail Error propagation (pkg/dcgm/diag.go, pkg/service/router/api.go): - Set ErrorCode=-1 and ErrorMessage from GemmTestResult.Error when a GEMM entry has an error, replacing the previous always-zero values that made failures invisible to callers CLI output (pkg/cmd/cli/diag.go): - Display valid mean alongside FAIL marker (e.g. hgemm=95.50(FAIL)) when a partial result is available - Print per-entry error detail lines below each HCU summary row Tests: - Add pkg/dcgm/gemmperf_test.go: valid mean parse, missing mean error, FAIL flag detection against real log format - Extend pkg/cmd/cli/diag_test.go: failed entry with valid mean and error detail rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkpassed..gitignoreis changed.