Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality control improvements #28

Merged
merged 13 commits into from
May 21, 2024
Merged

Conversation

max-ostapenko
Copy link

@max-ostapenko max-ostapenko commented May 4, 2024

Improving the maintenance effort as discussed in the doc.
Related to the issue #21.

The outline:

  • PR action picks up the updated technologies definitions and author-defined test URLs
  • It send technologies update to a WPT instance (assisted by @pmeenan)
  • Runs unit tests
  • Start a test for a list of URLs
  • Comments with the detected technologies in the PR

WPT nodeJS client PRs required for this workflow:

  1. Sync updates from upstream #3
  2. Pull the Wappalyzer config for a single test #4

@max-ostapenko
Copy link
Author

@rviscomi could we drop the requirement of providing technology icons?
It would simplify the contributions and maintenance effort.

@max-ostapenko
Copy link
Author

max-ostapenko commented May 4, 2024

@rviscomi Once you add the WPT key we should be able to see result of unit tests and technologies for the test websites run with the live version of rules.
With PROD technology rules while there is no WPT API yet.

And it seems that live tests are broken now: "wappalyzer_failed": 1,
UPD: Fix merged: #26

@rviscomi
Copy link
Member

rviscomi commented May 9, 2024

@rviscomi could we drop the requirement of providing technology icons?
It would simplify the contributions and maintenance effort.

We may want to display the icons in the CWV Tech Report (mockup) so let's try to keep it as a requirement if possible

@max-ostapenko
Copy link
Author

@rviscomi this PR is only waiting for a WPT API key saved in secrets to be ready for review.

@pmeenan
Copy link
Member

pmeenan commented May 9, 2024

@max-ostapenko HA_API_KEY is now set for this repository with an API key for the webpagetest.httparchive.org instance.

@max-ostapenko max-ostapenko marked this pull request as ready for review May 9, 2024 23:12
@max-ostapenko max-ostapenko marked this pull request as draft May 9, 2024 23:12
@max-ostapenko max-ostapenko marked this pull request as ready for review May 9, 2024 23:12
@max-ostapenko
Copy link
Author

max-ostapenko commented May 9, 2024

@pmeenan please review & merge.
Fork's PRs actions don't have access to secrets until merged.

@max-ostapenko max-ostapenko mentioned this pull request May 10, 2024
@pmeenan pmeenan merged commit 5fa9c0f into HTTPArchive:main May 21, 2024
@max-ostapenko max-ostapenko deleted the pr_action branch May 21, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants