-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media 2024 queries #3738
Media 2024 queries #3738
Conversation
Linter prefers '
Fixing inconsistencies in linter
Linter
How do you get around the of blocked regex 'TABLESAMPLE' error? I don't actually know what it does mind you... |
@mgifford I'm sorry, I don't understand. What error? |
However, eventually we will want all queries run on the full dataset. Therefore there is a linting rule warning this is being used and we should not merge this PR until that is fixed. So it's fine to ignore it for now (especially as this PR is still in Draft status) if you're still working on those queries. It just means you won't see a nice green tick in the linting check for now and also that you might miss other linting errors unless you explicitly look at those checks to see if anything else needs fixing too. |
Aaaah, I didn't realize there was a linting error. Thanks @tunetheweb! I've run most of the queries against the full data set already. and will double check that this is true! |
removing TABLESAMPLE SYSTEM (0.001 PERCENT)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. Still using some older tables in some queries but let's not perfection be the enemy of the good!
Let me know if good to merge, but I think you might still be working on some queries?
I've been writing off of the results of these - as far as I can tell they are good to merge! |
This PR includes the updated queries for the media chapter. #3596