Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskCanceledException when requesting AccessToken #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TaskCanceledException when requesting AccessToken #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/AGConnectAdmin/Messaging/AGConnectMessagingClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,20 +270,25 @@ private async Task<string> GetAccessTokenAsync()
string accessToken = tokenResponse?.GetValidAccessToken();
if (string.IsNullOrEmpty(accessToken))
{
lock (accessTokenTaskLock)
try
{
if (accessTokenTask == null)
lock (accessTokenTaskLock)
{
// access token task may be shared by multiple messaging task, thus should not pass cancellationToken to it
accessTokenTask = RequestAccessTokenAsync(default);
if (accessTokenTask == null)
{
// access token task may be shared by multiple messaging task, thus should not pass cancellationToken to it
accessTokenTask = RequestAccessTokenAsync(default);
}
}
}

accessToken = await accessTokenTask.ConfigureAwait(false);

lock (accessTokenTaskLock)
accessToken = await accessTokenTask.ConfigureAwait(false);
}
finally
{
accessTokenTask = null;
lock (accessTokenTaskLock)
{
accessTokenTask = null;
}
}
}

Expand Down