test: add coverage for paths.py validation utilities#114
Merged
tjb-tech merged 1 commit intoHKUDS:mainfrom Apr 9, 2026
Merged
Conversation
xzq-xu
force-pushed
the
test/paths-coverage
branch
from
8607a88 to
5ea782c
Compare
validate_identifier and ensure_within_root are the core path-safety primitives used across store, mailbox, and workspace modules but had zero dedicated tests. Adds 30 tests covering valid/invalid identifiers, allow_empty flag, custom error kind, path traversal via .., absolute segments, symlink escapes, and normal join behavior. Made-with: Cursor
xzq-xu
force-pushed
the
test/paths-coverage
branch
from
5ea782c to
f9a3a1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clawteam/paths.py:validate_identifierandensure_within_rootare the core path-safety primitives used across store, mailbox, and workspace modules but previously had zero dedicated tests.Test coverage includes:
validate_identifier(16 tests):.,..) are accepted by the regex — path traversal is handled byensure_within_rootallow_emptyflag behaviorkindparameter in error messagesensure_within_root(7 tests):..traversal rejection..escape rejectionTest plan
Made with Cursor