fix: quote pip version specifier in ci.yml & move asyncio import to module level - #7
Closed
salem221094 wants to merge 3 commits into
Closed
fix: quote pip version specifier in ci.yml & move asyncio import to module level#7salem221094 wants to merge 3 commits into
salem221094 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
CI run #24933019577 failed due to two bugs introduced in the
feat/mcp-servermerge (PR #6).Bug 1 — Shell interprets
>=as a redirect inci.ymlWithout quotes, bash treats
>=as an output redirect (>) followed by=0.4(a filename), so the install command fails before any linting can even begin.Bug 2 —
import asyncioinside function body inmcp_server.pyRuff's
I(isort) andE402rules require all standard-library imports to be at the top of the file. Havingimport asyncioinside the function body causesruff checkto fail.Changes
.github/workflows/ci.yml— quote thepip install "ruff>=0.4"argumentcatchme/mcp_server.py— moveimport asyncioto the module-level imports block