Skip to content

fix(freecad): sanitize output_path in macro generation to prevent code injection #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastiondev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(freecad): sanitize output_path in macro generation to prevent code injection #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions freecad/agent-harness/cli_anything/freecad/utils/freecad_macro_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def _gen_export(
lines: List[str] = []

# Escape backslashes for Windows paths in the generated Python script
safe_path = output_path.replace("\\", "/")
safe_path = repr(output_path.replace("\\", "/"))

# Recompute the document before exporting
lines.append("doc.recompute()")
Expand All @@ -548,22 +548,22 @@ def _gen_export(
fmt = export_format.lower()

if fmt in ("step", "iges", "brep"):
lines.append(f"Part.export(export_objects, '{safe_path}')")
lines.append(f"Part.export(export_objects, {safe_path})")

elif fmt in ("stl", "obj"):
lines.append("import Mesh")
lines.append(f"Mesh.export(export_objects, '{safe_path}')")
lines.append(f"Mesh.export(export_objects, {safe_path})")

elif fmt == "fcstd":
lines.append(f"doc.saveAs('{safe_path}')")
lines.append(f"doc.saveAs({safe_path})")

else:
# Fallback to Part.export for unknown formats
lines.append(f"# Unknown format '{fmt}', attempting Part.export")
lines.append(f"Part.export(export_objects, '{safe_path}')")
lines.append(f"Part.export(export_objects, {safe_path})")

lines.append("")
lines.append("print('Export complete:', os.path.abspath('{safe_path}'))")
lines.append(f"print('Export complete:', os.path.abspath({safe_path}))")
lines.append("")

return lines
Expand Down
Loading