-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to read TEfficiency #275
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 90.51% 90.54% +0.03%
==========================================
Files 5 5
Lines 1117 1121 +4
Branches 237 230 -7
==========================================
+ Hits 1011 1015 +4
Misses 78 78
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @longjon929 -- thanks for your contribution! It would be great if you added some small tests to make sure the code works as expected and we will not break it in the future when making further changes. Do you think you could add some? Have a look at how we test other parts of the code and let me know if you need help. |
@clelange I will try to take a look when I get a chance. |
""" | ||
name = "teff" | ||
|
||
teff = ROOT.TEfficiency(name, name, 2, 0, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like pylint
has an issue with this line:
tests/test_rootfilereader.py:186:15: E1101: Module 'ROOT' has no 'TEfficiency' member (no-member)
I encountered this issue when upgrading the pylint
version in PR #260. The workaround was to add # pylint: disable=no-member
to the end of the affected lines (see commit 3a0f1ea).
By the way, the developer docs advise that pylint
should be run locally before pushing to GitHub to check for any issues. You might also want to consider extending the section of the docs on Reading from ROOT files (source in docs/usage.rst
) to mention the new functionality. Thanks for your contribution!
Adds a function to read in TEfficiency by creating a TGraph and feeding that into the existing TGraph reader.
📚 Documentation preview 📚: https://hepdata-lib--275.org.readthedocs.build/en/275/