New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry with a small number of rotations in phi direction #9

Merged

SanghyunKo merged 3 commits into HEP-FCC:master from SanghyunKo:master

Oct 8, 2020

Collaborator

SanghyunKo commented Oct 7, 2020

Changes proposed in this pull request:

Adding geometry description with 5m x 5m inner space with a small number of rotations in phi direction (which @lopezzot asked)
Also addresses some corner cases (filling fibres at the upper corner of the trapezoid as well) when the size of a single tower is very large

To be done:

Placing fibres & SiPMs takes very long time when the size of a tower is large (Use of std::strcmp at TGeo slows down DD4hep geometry construction #8)

SanghyunKo added 3 commits

September 10, 2020 14:38


          take care corner cases of small # of rotations in phi

c7d080a


          estimate numx & numy on-the-fly instead of saving them in CellID (ove…

3946dcc

…rflow of field with small # of rotations)


          fix readouts

6bc8d86

SanghyunKo merged commit 0f90992 into HEP-FCC:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet