fix: graphql-ruby 2.3 compatibility #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bad practice to commit Gemfile.lock files into gem repositories - `gemspec` files should be the source of truth for dependencies. I removed all Gemfile.lock files and updated the CircleCI configuration to use the Gemfile for cache keys. Additionally, I updated the `rack` development dependency in the gemspec and locked it to version 2.0 because of the breaking changes in version 3.
Bajena
changed the title
|
When can we expect this to be merged? |
|
@sethc2 could you please merge this? 🙏 or delegate to another maintainer? Thanks in advance. |
sethc2
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Everything looks good but because we utilize dependabot I think we generally prefer if we keep the Gemfile.lock. We follow Bundler's guidance here
Would you be opposed to adding the gemfile.lock(s) back in? We have been doing very little maintenance on this repository for the past couple years (see discussion here), and want to avoid any accidental breaking changes in dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires merging #276 first
fixes #276
This PR:
graphql-ruby 2.3Tracermethod to support the new way of module-based tracing (https://graphql-ruby.org/queries/tracing)trace_withmethod in federated serviceswardenmethod.