Add background wave parallax #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit f819c37): https://gunnwatt--pr56-parallax-uc5oaglu.web.app (expires Thu, 16 Sep 2021 18:27:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
SheepTester
reviewed
Sep 9, 2021
Comment on lines
+16
to
+19
| document.addEventListener('wheel', handleScroll); | ||
| return function cleanup() { | ||
| document.removeEventListener('wheel', handleScroll); | ||
| } |
There was a problem hiding this comment.
Use the scroll event since that's the actual event that is dispatched when the scroll position changes. The wheel event is dispatched when the scroll wheel moves, but that is not a perfect correlation with scrolling; the scroll wheel is also used for zooming (zooming by pinching with the trackpad dispatches wheel events with ctrlKey set to true), and the page can be scrolled without using the scroll wheel (using a finger, arrow keys, tab key, URL fragments, and Windows smooth scrolling)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to test whether the parallax is just as choppy on the production build as it is on localhost.