Code

Lambda inlining optimization#353

Code

Open

TimothyGeerkensGuardsquare wants to merge 87 commits intoGuardsquare:masterGuardsquare/proguard:masterfrom MaartenS11:lambda-inliningMaartenS11/proguard:lambda-inliningCopy head branch name to clipboard

+5,284-1

Commits

Commits on Aug 3, 2023

• Added lambda inlining

  Show description for 274fd19
  

  TimothyGeerkensGuardsquare

  and

  MaartenS11

  committed
  274fd19

  Copy full SHA for 274fd19

Commits on Aug 4, 2023

• Fixes from inlining lambdas in the klox compiler

  Show description for 043be3a
  MaartenS11

  committed
  043be3a

  Copy full SHA for 043be3a

• Added test for retracer + addressed Oberon's comment from index 1 to 9

  TimothyGeerkensGuardsquare

  committed
  c098ad8

  Copy full SHA for c098ad8

Commits on Aug 7, 2023

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into klox-fixes

  MaartenS11

  committed
  7922f11

  Copy full SHA for 7922f11

• Fixed regression from merge

  MaartenS11

  committed
  bb66672

  Copy full SHA for bb66672

• Removed some unused fields from the RecursiveInliner

  MaartenS11

  committed
  573995e

  Copy full SHA for 573995e

• Removed import .* in LambdaLocator

  Show description for e4ce1e0
  TimothyGeerkensGuardsquare

  committed
  e4ce1e0

  Copy full SHA for e4ce1e0

• Simplified the RecursiveInliner a bit

  Show description for 70e5966
  MaartenS11

  committed
  70e5966

  Copy full SHA for 70e5966

• Cleaned up RecursiveInliner by moving some code into a new CalledMethodHandler class

  MaartenS11

  committed
  aabc5bd

  Copy full SHA for aabc5bd

• Move some code into IndyLambdaImplVisitor class

  MaartenS11

  committed
  f4a22fa

  Copy full SHA for f4a22fa

• Remove argument from RecursiveInliner because it isn't really needed anymore

  MaartenS11

  committed
  7b2146e

  Copy full SHA for 7b2146e

• Reduce line length a bit by putting index calculation in a variable

  MaartenS11

  committed
  3573c19

  Copy full SHA for 3573c19

• Remove wildcard imports from RecursiveInliner

  MaartenS11

  committed
  025571c

  Copy full SHA for 025571c

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into klox-fixes

  MaartenS11

  committed
  845d044

  Copy full SHA for 845d044

• Removed visitor staircase in LambdaLocator

  Show description for 13b38d5
  TimothyGeerkensGuardsquare

  committed
  13b38d5

  Copy full SHA for 13b38d5

• Removed wildcards in import

  Show description for fb9fe7d
  TimothyGeerkensGuardsquare

  committed
  fb9fe7d

  Copy full SHA for fb9fe7d

• Cleaned up the while loop in the LambdaUsageFinder by using the new IterativeInstructionVisitor class

  MaartenS11

  committed
  cf74760

  Copy full SHA for cf74760

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into klox-fixes

  MaartenS11

  committed
  2090514

  Copy full SHA for 2090514

• Merge pull request #1 from MaartenS11/klox-fixes

  Show description for fb5eedb
  MaartenS11

  authored
  fb5eedb

  Copy full SHA for fb5eedb

• Removed unused class and method

  Show description for 6ae5fc3
  TimothyGeerkensGuardsquare

  committed
  6ae5fc3

  Copy full SHA for 6ae5fc3

• merge

  TimothyGeerkensGuardsquare

  committed
  e90c5c9

  Copy full SHA for e90c5c9

• Add more comments to the RecursiveInliner

  MaartenS11

  committed
  33aa83d

  Copy full SHA for 33aa83d

• removed print and added logging

  TimothyGeerkensGuardsquare

  committed
  1d49b49

  Copy full SHA for 1d49b49

• refactored test and added performance tests

  TimothyGeerkensGuardsquare

  committed
  cb60c13

  Copy full SHA for cb60c13

• Only stop inlining if we actually have the current lambda in one of the arguments

  MaartenS11

  committed
  3d3bf8f

  Copy full SHA for 3d3bf8f

Commits on Aug 8, 2023

• refactored util

  TimothyGeerkensGuardsquare

  committed
  8c354ab

  Copy full SHA for 8c354ab

• Use argument index from LambdaUsageFinder instead of searching in the descriptor

  Show description for 813be34
  MaartenS11

  committed
  813be34

  Copy full SHA for 813be34

• RecursiveInliner should also use the argument index from the lambda usage finder

  MaartenS11

  committed
  f155107

  Copy full SHA for f155107

• Remove findFirstLambdaParameter method since it is no longer needed

  MaartenS11

  committed
  7d82d2d

  Copy full SHA for 7d82d2d

• WIP commit (please amend)

  MaartenS11

  committed
  047719c

  Copy full SHA for 047719c

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into recursive-inliner-adjustments

  MaartenS11

  committed
  5cc6748

  Copy full SHA for 5cc6748

• Merge pull request #2 from MaartenS11/recursive-inliner-adjustments

  Show description for 1f5c85b
  MaartenS11

  authored
  1f5c85b

  Copy full SHA for 1f5c85b

• Put stop condition that was duplicated into a method

  MaartenS11

  committed
  54233a5

  Copy full SHA for 54233a5

• Don't hardcode the MethodInliner max resulting code size

  MaartenS11

  committed
  ef37241

  Copy full SHA for ef37241

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into more-fixes

  MaartenS11

  committed
  beeadd5

  Copy full SHA for beeadd5

• Fixed cast removal so it works in all cases

  MaartenS11

  committed
  343df22

  Copy full SHA for 343df22

• Reverted some minor accidental changes

  MaartenS11

  committed
  71213fe

  Copy full SHA for 71213fe

• Cleaned up a bit

  MaartenS11

  committed
  42493c6

  Copy full SHA for 42493c6

• Merge pull request #3 from MaartenS11/more-fixes

  Show description for 8cfd505
  MaartenS11

  authored
  8cfd505

  Copy full SHA for 8cfd505

Commits on Aug 9, 2023

• Conditionally inline lambdas

  MaartenS11

  committed
  cff6565

  Copy full SHA for cff6565

• Added logging when a lambda has been inlined and only print method length when decided to not inline the lambda

  MaartenS11

  committed
  5644a9d

  Copy full SHA for 5644a9d

• Log the consuming method and invoke method so the use knows which method is not inlined when it is too long

  MaartenS11

  committed
  48c52e5

  Copy full SHA for 48c52e5

• Merge pull request #4 from MaartenS11/inline-conditionally

  Show description for badf492
  MaartenS11

  authored
  badf492

  Copy full SHA for badf492

• Fixed typo in comment

  Show description for 61e1e98
  

  MaartenS11

  and

  rubenpieters

  authored
  61e1e98

  Copy full SHA for 61e1e98

• Removed some unnecessary comments from the tests

  MaartenS11

  committed
  00664b2

  Copy full SHA for 00664b2

• Fixed typo in comment

  Show description for fca2cde
  

  MaartenS11

  and

  rubenpieters

  authored
  fca2cde

  Copy full SHA for fca2cde

• Rename package to lambdainline instead of lambdaInline

  MaartenS11

  committed
  f8f1155

  Copy full SHA for f8f1155

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into lambda-inlining

  MaartenS11

  committed
  bcab91e

  Copy full SHA for bcab91e

• Rename lambda_locator package to lambdalocator

  MaartenS11

  committed
  2710ff3

  Copy full SHA for 2710ff3

• Added newline to Lambda class and removed some unneeded methods

  MaartenS11

  committed
  49bd302

  Copy full SHA for 49bd302

• Use result of lambdaUsageHandler.handle() directly instead of storing and then reading it again from the iterativeInstructionVisitor

  MaartenS11

  committed
  55b4f0e

  Copy full SHA for 55b4f0e

• This doesn't have to be a nested if

  MaartenS11

  committed
  7613999

  Copy full SHA for 7613999

• Added more javadoc comments to the IterativeInstructionVisitor

  MaartenS11

  committed
  ee3e3ab

  Copy full SHA for ee3e3ab

• Added more javadoc strings and fixed a typo

  MaartenS11

  committed
  f1ba773

  Copy full SHA for f1ba773

• Renamed isSourceInstruction to isNotSourceInstruction

  Show description for 7d602c9
  TimothyGeerkensGuardsquare

  committed
  7d602c9

  Copy full SHA for 7d602c9

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into lambda-inlining

  TimothyGeerkensGuardsquare

  committed
  4d18370

  Copy full SHA for 4d18370

• Added more javadoc comments

  MaartenS11

  committed
  2648338

  Copy full SHA for 2648338

• Apply suggestions from code review

  Show description for b431cb7
  

  MaartenS11

  and

  rubenpieters

  authored
  b431cb7

  Copy full SHA for b431cb7

• Use Optional in MethodLengthFinder so the programmer is made aware that some methods don't have a length

  MaartenS11

  committed
  11f21f1

  Copy full SHA for 11f21f1

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into lambda-inlining

  MaartenS11

  committed
  028e8c4

  Copy full SHA for 028e8c4

• Return ProgramMethod instead of just Method

  MaartenS11

  committed
  0cc53cd

  Copy full SHA for 0cc53cd

• Use the name kotlin lambdas instead of static lambdas in the LambdaLocator

  MaartenS11

  committed
  a440b45

  Copy full SHA for a440b45

• Renamed constantInstruction and offset to be more precise also added javadoc to Lambda class to explain what each argument/field represents

  MaartenS11

  committed
  7e652b3

  Copy full SHA for 7e652b3

Commits on Aug 10, 2023

• Added more info about what "a lambda" really means

  MaartenS11

  committed
  607bf86

  Copy full SHA for 607bf86

• Change some things to the FixedPointCodeAttributeVisitor API

  MaartenS11

  committed
  f69fd14

  Copy full SHA for f69fd14

• invokespecial is now considered a potential source for the sourcetracer

  Show description for 95b23ab
  TimothyGeerkensGuardsquare

  committed
  95b23ab

  Copy full SHA for 95b23ab

• merge

  TimothyGeerkensGuardsquare

  committed
  c5bca4a

  Copy full SHA for c5bca4a

• Use library and program class pools instead of passing AppView

  MaartenS11

  committed
  23d4efe

  Copy full SHA for 23d4efe

• Merge branch 'lambda-inlining' of github.com:MaartenS11/proguard into lambda-inlining

  MaartenS11

  committed
  7cdac26

  Copy full SHA for 7cdac26

• Made one of the debug log messages info again because it was accidentally changed

  MaartenS11

  committed
  03ae5c6

  Copy full SHA for 03ae5c6

• Add large javadoc comment explaining all the steps taken when using the BaseLambdaInliner.inline() method

  MaartenS11

  committed
  ad8b5ff

  Copy full SHA for ad8b5ff

• Added comment explaining why descriptor is changed to use unboxed types

  MaartenS11

  committed
  26d9850

  Copy full SHA for 26d9850

• Move a lot of code from the BaseLambdaInliner into a private inner class because the visitors are not part of the API of the BaseLambdaInliner

  MaartenS11

  committed
  a5ebb5e

  Copy full SHA for a5ebb5e

• Fixed incorrect comment mentioning method that no longer exists

  MaartenS11

  committed
  71b63a4

  Copy full SHA for 71b63a4

• Disable replacing usages with aconst_null

  MaartenS11

  committed
  7da8e01

  Copy full SHA for 7da8e01

• Add -inlinekotlinlambdas command line option to enable and disable lambda inlining without recompiling

  MaartenS11

  committed
  751cc74

  Copy full SHA for 751cc74

• Moved lambda inlining optimization from inline to lambdainline package so it matches the package name used in the tests and it also is just more informative, the MethodInliner for example was not i…

  Show description for f4f84e4
  MaartenS11

  committed
  f4f84e4

  Copy full SHA for f4f84e4

• Add CannotInlineException message to debug log

  MaartenS11

  committed
  9d080b2

  Copy full SHA for 9d080b2

Commits on Aug 11, 2023

• Add ProGuard header to every class

  MaartenS11

  committed
  b8fbcd0

  Copy full SHA for b8fbcd0

• Added detection for the second null check method for parameters in Kotlin

  MaartenS11

  committed
  3a866fc

  Copy full SHA for 3a866fc

• Added WIP README file to the lambdainline package

  Show description for a910309
  MaartenS11

  committed
  a910309

  Copy full SHA for a910309

• Fix example and explain more about the cast removal/boxing/unboxing

  MaartenS11

  committed
  0cf13a7

  Copy full SHA for 0cf13a7

• Mention a bit more which classes are used to do which operations

  MaartenS11

  committed
  1ba33ba

  Copy full SHA for 1ba33ba

Commits on Aug 12, 2023

• Be more specific when using the ClassReferenceInitializer, not all references have to be updated, just the classes involved in the inlining process

  Show description for ceea1b6
  MaartenS11

  committed
  ceea1b6

  Copy full SHA for ceea1b6

• Only re-run the ClassReferenceInitializer on the consuming class

  Show description for 93d3bb6
  MaartenS11

  committed
  93d3bb6

  Copy full SHA for 93d3bb6

• Only run AccessFixer on consumingClass instead of the entire programClassPool

  Show description for ac7f42d
  MaartenS11

  committed
  ac7f42d

  Copy full SHA for ac7f42d

Commits on Aug 13, 2023

• Adjust conditional inlining attempt condition to use sum of consuming method and lambda length

  MaartenS11

  committed
  370704b

  Copy full SHA for 370704b