Skip to content

⚡ Replace synchronous I/O in Async Context in setup command #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GreyC wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

⚡ Replace synchronous I/O in Async Context in setup command #19

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aad0245
perf: replace synchronous I/O with asynchronous I/O in setup command
GreyC Mar 13, 2026
9262ead
perf: replace synchronous I/O with asynchronous I/O in setup command
GreyC Mar 13, 2026
889c77b
perf: replace synchronous I/O with asynchronous I/O in setup command
GreyC Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,10 @@ program
await JulesClient.validateKey(apiKey);

const configDir = path.join(os.homedir(), '.config', 'jules');
if (!fs.existsSync(configDir)) {
fs.mkdirSync(configDir, { recursive: true });
}
await fs.promises.mkdir(configDir, { recursive: true });
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

To protect the sensitive API key, the directory permissions should be restricted. Setting mode: 0o700 ensures that only the owner can access this directory, which is a crucial security measure for storing credentials.

Suggested change
await fs.promises.mkdir(configDir, { recursive: true });
await fs.promises.mkdir(configDir, { recursive: true, mode: 0o700 });

Copy link
Copy Markdown
Owner Author

@GreyC GreyC Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jules

Copy link
Copy Markdown
Contributor

@google-labs-jules google-labs-jules bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced the synchronous fs.mkdirSync call with await fs.promises.mkdir(configDir, { recursive: true }). This is an asynchronous operation that doesn't block the event loop and it's idempotent, meaning it won't throw an error if the directory already exists, effectively replacing the previous fs.existsSync check as well.


const configPath = path.join(configDir, 'config.json');
fs.writeFileSync(configPath, JSON.stringify({ apiKey }, null, 2));
await fs.promises.writeFile(configPath, JSON.stringify({ apiKey }, null, 2));
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

The configuration file contains a sensitive API key and should have restricted permissions. Setting mode: 0o600 will ensure only the file owner has read and write access, preventing potential exposure on a multi-user system.

Suggested change
await fs.promises.writeFile(configPath, JSON.stringify({ apiKey }, null, 2));
await fs.promises.writeFile(configPath, JSON.stringify({ apiKey }, null, 2), { mode: 0o600 });

Copy link
Copy Markdown
Owner Author

@GreyC GreyC Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jules

Copy link
Copy Markdown
Contributor

@google-labs-jules google-labs-jules bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also updated the configuration file writing to use await fs.promises.writeFile. This ensures that saving the API key is fully asynchronous and does not block the event loop during the setup process.


console.log('Setup complete. API key saved to ~/.config/jules/config.json');
} catch (error: any) {
Expand Down
Loading