-
Notifications
You must be signed in to change notification settings - Fork 379
chore: shared pipeline under same catalog with compatibility #6143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: shared pipeline under same catalog with compatibility #6143
Conversation
I am afraid some users already use it in this way. The breaking may not be acceptable. |
Is it possible to do it in a semi-compatible way:
|
There is one obscure case. If there are multiple pipelines with the same name but none of them is under the current schema. This should be rare, we can throw an error if it occurs. Is this acceptable? |
Sounds good. |
b8bd0bf
to
a71ee54
Compare
@sunng87 @killme2008 PTAL |
I wonder that the cloud catalog doesn't contain a public schema; how do we process it? @shuiyisong |
This doesn't check the actual existence of the schema, which in this case is public. It's merely a string field in the |
Rest LGTM |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As mentioned here, remove the schema in the pipeline information and cache key, so that all databases under the same catalog can access the shared pipelines.Note: This is a breaking change. If the pipeline is already in use, check if pipelines have the same names but different schemas before upgrading.Allow shared pipeline under the same catalog.
cache
database
PR Checklist
Please convert it to a draft if some of the following conditions are not met.