Skip to content

fix: comments on the first line hang #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

QuakeWang
Copy link

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

fix: #6114

GreptimeDB fails to correctly execute SQL statements with comments on the first line, causing the MySQL client to hang.

image

After fix this error, test passed.

image

What's changed and what's your intention?

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@QuakeWang QuakeWang requested a review from a team as a code owner May 16, 2025 13:59
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 16, 2025
@killme2008
Copy link
Contributor

killme2008 commented May 16, 2025

Looks like it's not an issue; it doesn't hang, just awaits valid input. The real problem is that kill queries are currently unsupported (#5899).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to execute SQL statements with comments on the first line
2 participants