feat: Adds format helper for the plain format #6097
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
commented
May 14, 2025
Comment on lines
+237
to
+244
| /// Returns min/max values of specific columns. | ||
| /// Returns None if the column does not have statistics. | ||
| /// The column should not be encoded as a part of a primary key. | ||
| pub(crate) fn column_values( | ||
| row_groups: &[impl Borrow<RowGroupMetaData>], | ||
| column: &ColumnMetadata, | ||
| column_index: usize, | ||
| is_min: bool, |
There was a problem hiding this comment.
Just move the implementation of column_values() and column_null_counts() to this place.
12 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#6078
What's changed and what's your intention?
This PR adds helpers for the plain format:
The
PlainWriteFormatis quite simple as it only overrides sequences on demand.The
PlainReadFormatis similar toPrimaryKeyReadFormat. Since there is no primary key encoding, the read format can get the min/max value for each column.It renames the old helpers to
PrimaryKeyWriteFormatandPrimaryKeyReadFormat. TheReadFormatnow is an enum that wraps the two different formats.PR Checklist
Please convert it to a draft if some of the following conditions are not met.