-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct is_exceeded_size_limit
behavior for in-memory store
#5082
fix: correct is_exceeded_size_limit
behavior for in-memory store
#5082
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5082 +/- ##
==========================================
- Coverage 84.02% 83.80% -0.23%
==========================================
Files 1157 1157
Lines 216415 216477 +62
==========================================
- Hits 181849 181411 -438
- Misses 34566 35066 +500 |
…5082) * fix: correct `is_exceeded_size_limit` behavior for in-memory store * chore: rename `MetaClientExceededSizeLimit` to `ResponseExceededSizeLimit`
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR fixes the behavior of
PaginationStream
, ensuring it automatically adjusts the next request'spage_size
when the range response size from the in-memory store exceeds the size limit.Checklist