Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak in unit test of telemetry #3897

Merged
merged 1 commit into from
May 9, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented May 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Remove this:

let url = Box::leak(format!("{}:{}", "http://localhost", port).into_boxed_str());

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@waynexia waynexia requested a review from a team as a code owner May 9, 2024 14:17
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 9, 2024
@tisonkun tisonkun enabled auto-merge May 9, 2024 14:20
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

......

@tisonkun tisonkun added this pull request to the merge queue May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (b8a325d) to head (31e11c2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3897      +/-   ##
==========================================
- Coverage   86.03%   85.69%   -0.35%     
==========================================
  Files         955      955              
  Lines      163851   163870      +19     
==========================================
- Hits       140969   140427     -542     
- Misses      22882    23443     +561     

Merged via the queue into GreptimeTeam:main with commit 66aa08d May 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants