Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support querying field column names in Prometheus HTTP API #3880

Merged
merged 3 commits into from
May 8, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented May 8, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

The extended special matcher __field__ is used to specify which field to query in multi-field scenario. This patch adds support for querying the possible values of __field__

It works like
image

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@waynexia waynexia requested a review from a team as a code owner May 8, 2024 07:30
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 8, 2024
Signed-off-by: Ruihang Xia <[email protected]>
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 80.39216% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.33%. Comparing base (cc8d6b1) to head (5496530).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3880      +/-   ##
==========================================
- Coverage   85.63%   85.33%   -0.31%     
==========================================
  Files         952      952              
  Lines      163341   163496     +155     
==========================================
- Hits       139878   139515     -363     
- Misses      23463    23981     +518     

@waynexia waynexia enabled auto-merge May 8, 2024 08:00
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia requested a review from fengjiachun May 8, 2024 12:05
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue May 8, 2024
Merged via the queue into GreptimeTeam:main with commit a6a702d May 8, 2024
21 checks passed
@waynexia waynexia deleted the query-fields branch May 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants