Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add data type to vector cache key #3876

Merged
merged 4 commits into from
May 8, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented May 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds data type to the cache key for repeated vectors. It fixes the issue that different data types use the same null vector in the cache. When the reader gets a null vector from the cache, the data type of the vector might not be the expected type and result in the following error: column types must match schema types.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 7, 2024
@evenyag evenyag marked this pull request as ready for review May 7, 2024 11:06
@evenyag evenyag requested review from v0y4g3r, waynexia and a team as code owners May 7, 2024 11:06
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (154f561) to head (3729027).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3876      +/-   ##
==========================================
- Coverage   85.60%   85.35%   -0.25%     
==========================================
  Files         952      952              
  Lines      163079   163379     +300     
==========================================
- Hits       139596   139450     -146     
- Misses      23483    23929     +446     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue May 8, 2024
Merged via the queue into GreptimeTeam:main with commit 9d8f72d May 8, 2024
35 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column types doesn't match schema types
3 participants