Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove one slice copy in wal encoding #3861

Merged
merged 2 commits into from
May 6, 2024
Merged

chore: remove one slice copy in wal encoding #3861

merged 2 commits into from
May 6, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented May 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR removes one slice copy in wal encoding.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@v0y4g3r v0y4g3r requested review from evenyag and waynexia as code owners May 6, 2024 09:17
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 6, 2024
waynexia
waynexia approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/log-store/src/noop.rs Outdated Show resolved Hide resolved
tisonkun
tisonkun approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun added this pull request to the merge queue May 6, 2024
Merged via the queue into GreptimeTeam:main with commit f3b6825 May 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@waynexia waynexia waynexia approved these changes

@evenyag evenyag Awaiting requested review from evenyag evenyag is a code owner

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v0y4g3r @waynexia @tisonkun