feat: Implement OR for PromQL #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
github-actions
bot
added
docs-not-required
waynexia
requested review from
killme2008,
yuanbohan,
Taylor-lagrange and
alili
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3024 +/- ##
===========================================
- Coverage 85.70% 85.02% -0.69%
===========================================
Files 784 793 +9
Lines 126856 128346 +1490
===========================================
+ Hits 108726 109129 +403
- Misses 18130 19217 +1087 |
yuanbohan
approved these changes
Dec 28, 2023
killme2008
reviewed
Dec 28, 2023
Co-authored-by: dennis zhuang <[email protected]>
killme2008
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements
ORoperator for PromQL. SeeUnionDistinctOn's document for detailed explain.Notice that there are a few unresolved problems in this patch. I'll file another one to resolve them since this PR reaches it size limit
Checklist
Refer to a related PR or issue link (optional)
#1042