Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl quantile_over_time function #1287

Merged
merged 5 commits into from
Apr 2, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Mar 30, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Implement quantile_over_time() function in PromQL. This PR also fixes a schema bug with time() function

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Ref to #1042

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #1287 (802da7c) into develop (3e51640) will decrease coverage by 0.70%.
The diff coverage is 46.15%.

@@             Coverage Diff             @@
##           develop    #1287      +/-   ##
===========================================
- Coverage    86.16%   85.46%   -0.70%     
===========================================
  Files          494      495       +1     
  Lines        74686    74840     +154     
===========================================
- Hits         64352    63961     -391     
- Misses       10334    10879     +545     

@waynexia waynexia requested review from killme2008, MichaelScofield and yuanbohan and removed request for killme2008 and MichaelScofield March 31, 2023 14:32
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield merged commit c0132e6 into GreptimeTeam:develop Apr 2, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix qualifier alias

Signed-off-by: Ruihang Xia <[email protected]>

* fix in another way

Signed-off-by: Ruihang Xia <[email protected]>

* impl quantile_over_time

Signed-off-by: Ruihang Xia <[email protected]>

* fix clippy

Signed-off-by: Ruihang Xia <[email protected]>

---------

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants