Fix creating new image if file is unchanged. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garygreen
force-pushed
the
fix-image-unchanged
branch
3 times, most recently
from
7f604d5
to
f23f1a8
Compare
garygreen
force-pushed
the
fix-image-unchanged
branch
from
f23f1a8
to
b5bd0d9
Compare
|
@Gregwar any news on this? |
|
👍 really important fix |
|
Why the quality have to be 100 for this? |
|
Because it essentially means your not changing the image. If you wanted 100% of the original quality image, that means you just want to copy it. If it's 99% that means you want to change the image to a 1% lower quality version. That's how I see it anyway... |
|
Any news @Gregwar ? |
|
@Gregwar @soullivaneuh any news on this? At this rate I'll have to maintain a separate fork as this package seems quite slow on PRs at the moment.... 😢 |
|
@Gregwar Bump again, any news buddy? 😄 |
|
Hello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115.