Skip to content

Simplify armor logic #4431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Reabstraction merged 1 commit into from
Jan 6, 2026
Merged

Simplify armor logic #4431

Reabstraction merged 1 commit into from
Jan 6, 2026

Conversation

@jurrejelle
Copy link
Contributor

@jurrejelle jurrejelle commented Jan 6, 2026

What

Extracted from #4424

@jurrejelle jurrejelle requested a review from a team as a code owner January 6, 2026 16:00
@jurrejelle jurrejelle added 1.21 ignore changelog PR should not be added to the changelog. type: refactor Suggestion to refactor a section of code Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Jan 6, 2026
Reabstraction
Reabstraction approved these changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@Reabstraction Reabstraction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Reabstraction Reabstraction enabled auto-merge (squash) January 6, 2026 16:01
@Reabstraction Reabstraction merged commit 052866d into 1.21 Jan 6, 2026
5 of 7 checks passed
@Reabstraction Reabstraction deleted the jj/1.21/simplify-armor-logic branch January 6, 2026 16:02
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Reabstraction Reabstraction Reabstraction approved these changes

Assignees

No one assigned

Labels

1.21 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: refactor Suggestion to refactor a section of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jurrejelle @Reabstraction