Use Generic Builder pattern for MachineBuilder #4422
+337
−563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurrejelle
added
type: refactor
jurrejelle
force-pushed
the
jj/move-multiblock-builder-to-generic-system
branch
from
4d10523 to
11a51c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add second generic to MachineBuilder and reduce code duplication
Implementation Details
go from
MachineBuilder<DEFINITION extends MachineDefinition> extends BuilderBase<DEFINITION>toMachineBuilder<DEFINITION extends MachineDefinition, TYPE extends MachineBuilder<DEFINITION, TYPE>> extends BuilderBase<DEFINITION>Outcome
No longer need to add a
public MultiblockMachineBuilder foo(Bar bar){ (MultiblockMachineBuilder) super.foo(bar) };for every. single. MachineBuilder. method.Additional Information
Unfortunately Lombok doesn't support returning getThis() and TYPE, so I had to un-lombok both classes for setters.
Genericslop.
Potential Compatibility Issues
People who store partially finished builders need to move from MachineBuilder to MachineBuilder