Fix multiblock controller rotation overlay logic #4199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the multiblock controller rotation overlay logic when holding a wrench and not sneaking should be unified with the singleblock logic, where the front face of the machine shows the TOOL_FRONT_FACING_ROTATION - that singleblock logic is in SimpleTieredMachine::sideTips()
YoungOnionMC
approved these changes
Nov 18, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
screret
previously requested changes
Nov 18, 2025
src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java
Outdated
Show resolved
Hide resolved
YoungOnionMC
added
type: bugfix
Co-authored-by: screret <[email protected]>
jurrejelle
approved these changes
Dec 13, 2025
Contributor
|
There was a typo in the suggestion, could you pull + add the missing ) + apply spotless + push? then I'll merge :) |
YoungOnionMC
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes #4098 and unifies the multiblock controller's rotation overlay behavior with the singleblock machine's overlay (when holding a wrench and not sneaking/sneaking)
The singleblock logic is here
Outcome
not sneaking
EBF:
LCR:
Electrolyzer:
sneaking
EBF:
LCR
Electrolyzer:
