Skip to content

Fix medical conditions' effects not working #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
screret wants to merge 28 commits into
base: 1.20.1
Choose a base branch
from
Open

Fix medical conditions' effects not working #4066

screret wants to merge 28 commits into from

Conversation

@screret
Copy link
Contributor

@screret screret commented Oct 12, 2025 •
edited
Loading

What

  • Fixed medical conditions caused by holding hazardous materials (e.g. cancer from uranium) not updating correctly.
  • Added some much needed documentation to the system and made the /medical_condition query command's output nicer to read.
  • Rebalanced the medical conditions so their symptoms take longer to apply and aren't as drastic

I also chose to remove berylliosis and silicosis entirely, as they didn't actually do much and were just annoying to have around.

Implementation Details

  • MADE MEDICAL CONDITIONS USE AN ACTUAL REGISTRY INSTEAD OF A MAP
    • this shouldn't affect anyone too much, as I don't know anyone who actually used the system
  • Fixed invulnerability/hitstun/etc. breaking the death symptom
  • Fixed high levels of resistance being able to block medical condition damage (like death.)
  • Fixed the player's max health not updating until they take damage
  • Fixed the player's max breath (the air bubbles) not updating at all
  • Made the hazardous item tracker respect the held items' stack sizes and material amounts where they previvously didn't.
  • Renamed some methods' parameters to make more sense and added clarifying comments to them & others
  • Added separate lang keys for conditions affecting a player so the output of /medical_condition query makes sense. It now display something like this (1) instead of the previous (2)

new display

Player Dev has
Cancer for 10 minutes 5 seconds

old display

Player Dev has these medical conditions:
Condition Carcinogenic: 10 minutes 5 seconds

Outcome

  • The player's health and air is actually displayed as going down
  • The player gets the intermediate symptoms instead of, say, randomly dying from cancer
  • People won't get blinded by methanol the instant they touch it
  • Cancer now takes much longer to do anything drastic, and after that, the effects take longer to reach their full potential

Additional Information

Balance people should look over the tweaks at least a bit

Potential Compatibility Issues

The change to a "real" registry could make some people have issues but, as already mentioned, I don't know anyone who used the system.

screret added 25 commits October 2, 2025 16:05
@screret
clean up medical condition-related translation keys
8d78f91
@screret
make medical conditions use an actual registry instead of faking one
2dd369a
@screret
rename a couple methods' parameters, add clarifying comments to some,…
96d4ca4 
… shortcuts for others
@screret
add documentation on how lang keys are chosen for medical condition
67a76ad
@screret
special case the health debuff condition so it can resync the player'…
60e5659 
…s health
@screret
add a "consumption" hazard trigger that triggers when a player eats s…
763bf1c 
…omething
@screret
symptom that gives the darkness effect (the one wardens use)
9baf0b5
@screret
add separate "affected" text for most conditions because "Player <pla…
7bd0bce 
…yer> has: Carcinogenic" looks bad

fixes GregTechCEu#2780
@screret
fix compile errors
73b12fa
@screret
spotless, datagen
e497cb3
@screret
make fastutil be loaded from maven central so we can get its source a…
548aea3 
…rtifacts
@screret
merge IMedicalConditionTracker into MedicalConditionTracker
7d1d121 
most uses required the concrete class anyway
@screret
use absolute values for symptoms for clarity
2933348
@screret
remove silicosis and berylliosis as they were only annoying and added…
e46ac75 
… even less than the other conditions
@screret
track the max air symptom's value changes in the entity rather than t…
7229894 
…he tracker for efficiency
@screret
use fastutil reference maps for the progress tracking so we don't was…
8883f62 
…te time comparing
@screret
add descriptions of the various "generic" conditions to GTMedicalCond…
cdc4a6f 
…itions
@screret
spotless
7c3a79b
@screret
tweak the language of /medical_condition query to be easier to read…
7395929 
…, datagen
@screret
respect the item's material amount when progressing conditions
1d00512
@screret
reset air supply debuff when clearing effects
8e99861
@screret
properly remove cleared conditions' symptoms
1501ca7
@screret
allow passing negative values into `/medical_condition apply <conditi…
e90818d 
…on> [progression]`
@screret
tag all medical condition damage types as bypasses_cooldown
9d65d51
@screret
datagen
c7c66d0
@screret screret requested a review from a team as a code owner October 12, 2025 15:38
Reabstraction
Reabstraction reviewed Dec 13, 2025
View reviewed changes
gradle/scripts/repositories.gradle
repositories {
mavenLocal()
mavenCentral()
// force gradle to download FastUtil from the central maven so we can get source artifacts
Copy link
Contributor

@Reabstraction Reabstraction Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be made into its own PR

@screret
Merge branch '1.20.1' into sc/fix-medical-conditions
3a75ee2 
# Conflicts:
#	src/generated/resources/assets/gtceu/lang/en_ud.json
#	src/generated/resources/assets/gtceu/lang/en_us.json
#	src/main/java/com/gregtechceu/gtceu/data/lang/LangHandler.java
#	src/main/resources/assets/gtceu/lang/uk_ua.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Reabstraction Reabstraction Reabstraction left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

1.20.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@screret @Reabstraction