Allow drawing non-living entities with EntityDrawable (and port f61dc8e) #4065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t f61dc8e from 1.12
…lls; it did nothing, as the text render type uses translucency and always enables blending.
…` from `ModularGuiContext`, as the MUI screen requirement was unnecessary
…ository so it can find their sources
YoungOnionMC
approved these changes
Oct 12, 2025
YoungOnionMC
added
type: bugfix
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/mui/drawable/text/StyledText.java # src/main/java/com/gregtechceu/gtceu/common/machine/muimachine/TestMuiMachine.java
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/mui/drawable/GuiDraw.java # src/main/java/com/gregtechceu/gtceu/api/mui/drawable/SpriteDrawable.java # src/main/java/com/gregtechceu/gtceu/api/mui/drawable/text/TextRenderer.java # src/main/java/com/gregtechceu/gtceu/client/mui/screen/viewport/GuiContext.java # src/main/java/com/gregtechceu/gtceu/common/machine/muimachine/TestMuiMachine.java
Contributor
Author
|
pls merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ported f61dc8e & and did some formatting tweaks
also removed render state calls that ended up doing nothing
and disabled spotless on the test ui layout code because it added annoying line breaks
Implementation Details
The code for drawing entities is mostly copied from
InventoryScreen#renderEntityInInventorywith minor tweaks (which should be commented)The render state modification calls should probably? be checked for if they actually did do something. I believe they didn't, though.
Outcome
can render item frames, boats, etc. non-living entities with
EntityDrawable