Speedup ae2 stocking hatches

[jurrejelle]

What

Removes a redundant check in stocking hatches

Implementation Details

We no longer simulate extracting for every item in the system, as this is expensive, and instead only simulate the 16 items we pick. This does mean inaccessable items will show up there, but that's user error, and they will show up as 0 amount.

Outcome

no longer 130us/t for a single stocking hatch

[jurrejelle]

Wait to merge until we get the OK from ghosti if it actually fixes the lag they cause

[jurrejelle]

• Update, this isn't the slow part, the slow part is

Back to the drawing board, idek if we can fix this in any reasonable way. Will need to discuss

[a-a-GiTHuB-a-a]

why is getStorageService underlined? like, what's the issue it's complaining about?

[jurrejelle]

why is getStorageService underlined? like, what's the issue it's complaining about?

possible nullpointer exception if the previous call returns null, but it shouldn't at that point. Regardless, as per the last commit we're rewriting it to use an ae2 storagemonitor service rather than just querying mainnet all the time

[TechLord22]

See prior comment - also can this code be deduplicated?

[jurrejelle]

Not in a clean way I could find, because of the usage of the slots, the fact that both lists dont have a shared superclass, etc