Remove --jobinfo, standalone config.yml file
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the need to update two places for documentation
Create standalone config.yml that is shipped with the cats installation, and is referred to by the main script and the Sphinx documentation.
abhidg
changed the title
--jobinfo, standalone config.yml file
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
2 tasks
tlestang
reviewed
Apr 23, 2024
tlestang
reviewed
Apr 23, 2024
tlestang
reviewed
Apr 23, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| [tool.setuptools] | |||
| packages = ["cats"] | |||
| package-data.cats = ["config.yml"] | |||
There was a problem hiding this comment.
I think config.yml would end up in lib/python3.X/site-packages/cats ? Might not be straightforward to use it from there?
There was a problem hiding this comment.
Can use relative file paths from __filename__
tlestang
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--jobinfoand document config.yml #87