Move gb-ui components into frontend - #1482
Conversation
8d736d0 to
f597539
Compare
|
Hey @cclts ! Should I already review? |
|
@regulartim Could you give me a little more time? I should be able to get to it by Friday! |
No worries, take your time! Just wanted to know. |
f597539 to
99c696c
Compare
|
I also migrated gb-ui’s table visual regression test into GreedyBear. Since the original test relied on gb-ui’s The visual test can be run manually with |
7473ae5 to
07d19f0
Compare
|
Hi @regulartim this pr is ready for review, if you have a chance please take a look thanks! |
|
I’m thinking adding a short Visual tests section to |
|
Tim is away for few weeks, considering this is not urgent matter, I'd prefer having him reviewing this work once he comes back. |
Summary
gb-uicomponents currently used by GreedyBear intofrontend/src/components/common/gb-ui/@greedybear/gb-uiimports with local imports@greedybear/gb-uidependency and declare the direct dependencies needed by the copied componentsRelated issues
#1454 option 1: Move the components we actually use to GreedyBear.
Type of change
Checklist
Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.
Formalities
<feature name>. Closes #999develop.develop.Docs and tests
Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.