Add distance validation in merge function and clamp grid coords #3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently the crash is fixed, but when you add a brush layer to the boolean group it rescales and moves the brush layer to the point where it is invisible. You are able to reset the scale and location via the properties menu and the brush re-appears. |
|
Not sure where the transforms are taking place, I can open as a separate issue if this is merged. |
|
@Keavon This is my first contribution to an open-source project, please let me know if you have any direct feedback to better assist my journey with contributing! |
|
Thanks, I will be busy for the next day or two as I get the next release out, then I'll try to take a look. Feel free to take on more issues in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3155 - Crash when merging brush layer into boolean layer in debug
both changes to rs files in node-graph, merge handling was improper, causing a panic with certain data types. Also clamped the grid points to avoid invalid data being passed.